Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36243 )
Change subject: vendorcode/intel/fsp/tigerlake: Add tigerlake FSP header file template
......................................................................
Patch Set 4:
Patch Set 4:
As the maintainer for github.com/IntelFSP, I would prefer that "early" UPD headers like this that solely exist to enable compilation of coreboot for unreleased SOCs be kept here in vendorcode. After the SOC is released and FSP binaries are posted at github.com/IntelFSP, I would prefer that the copy of the UPD headers here in vendorcode is deleted and the official headers provided at github.com/IntelFSP are used.
The reason is github.com/IntelFSP should only contain finished work that is ready for production use. The early headers won't meet that standard of quality.
I fully agree.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/36243
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia1d064ea60e3b7c2d1114771b07cf7ec7f0e2b37
Gerrit-Change-Number: 36243
Gerrit-PatchSet: 4
Gerrit-Owner: Ravishankar Sarawadi
ravishankar.sarawadi@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: John Zhao
john.zhao@intel.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Raj Astekar
raj.astekar@intel.com
Gerrit-Reviewer: Ravishankar Sarawadi
ravishankar.sarawadi@intel.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-CC: Nathaniel L Desimone
nathaniel.l.desimone@intel.com
Gerrit-CC: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Comment-Date: Tue, 05 Nov 2019 07:01:02 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment