Attention is currently required from: Raul Rangel, Karthik Ramasubramanian. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58660 )
Change subject: mb/google/guybrush: Move EN_PWR_FP from GPIO_32 to GPIO_3 ......................................................................
Patch Set 1:
(5 comments)
File src/mainboard/google/guybrush/variants/baseboard/gpio.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131541): https://review.coreboot.org/c/coreboot/+/58660/comment/265a41d2_3df82285 PS1, Line 356: const __weak struct soc_amd_gpio * variant_sleep_gpio_table(size_t *size) "foo * bar" should be "foo *bar"
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131541): https://review.coreboot.org/c/coreboot/+/58660/comment/c051f130_43d9856b PS1, Line 366: const __weak struct soc_amd_gpio *variant_fpmcu_shutdown_gpio_table(size_t *size) { open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131541): https://review.coreboot.org/c/coreboot/+/58660/comment/b41790a5_2c99aaa8 PS1, Line 371: const __weak struct soc_amd_gpio *variant_fpmcu_disable_gpio_table(size_t *size) { open brace '{' following function definitions go on the next line
File src/mainboard/google/guybrush/variants/guybrush/gpio.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131541): https://review.coreboot.org/c/coreboot/+/58660/comment/1b2e6347_3a86c3dc PS1, Line 122: const struct soc_amd_gpio *variant_fpmcu_shutdown_gpio_table(size_t *size) { open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131541): https://review.coreboot.org/c/coreboot/+/58660/comment/161554fc_7ec37b7c PS1, Line 127: const struct soc_amd_gpio *variant_fpmcu_disable_gpio_table(size_t *size) { open brace '{' following function definitions go on the next line