Attention is currently required from: Raul Rangel, Karthik Ramasubramanian.

View Change

5 comments:

• File src/mainboard/google/guybrush/variants/baseboard/gpio.c:

  • Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131541):

    Patch Set #1, Line 356: const __weak struct soc_amd_gpio * variant_sleep_gpio_table(size_t *size)

    "foo * bar" should be "foo *bar"

  • Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131541):

    Patch Set #1, Line 366: const __weak struct soc_amd_gpio *variant_fpmcu_shutdown_gpio_table(size_t *size) {

    open brace '{' following function definitions go on the next line

  • Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131541):

    Patch Set #1, Line 371: const __weak struct soc_amd_gpio *variant_fpmcu_disable_gpio_table(size_t *size) {

    open brace '{' following function definitions go on the next line

• File src/mainboard/google/guybrush/variants/guybrush/gpio.c:

  • Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131541):

    Patch Set #1, Line 122: const struct soc_amd_gpio *variant_fpmcu_shutdown_gpio_table(size_t *size) {

    open brace '{' following function definitions go on the next line

  • Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131541):

    Patch Set #1, Line 127: const struct soc_amd_gpio *variant_fpmcu_disable_gpio_table(size_t *size) {

    open brace '{' following function definitions go on the next line

To view, visit change 58660. To unsubscribe, or for help writing mail filters, visit settings.