Nick Vaccaro has submitted this change. ( https://review.coreboot.org/c/coreboot/+/69579 )
(
2 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: mb/google/brya: Enable Fast VMode for brya0, skolas and skolas4es ......................................................................
mb/google/brya: Enable Fast VMode for brya0, skolas and skolas4es
Fast VMode nmakes the SoC throttle when the current exceeds the I_TRIP threshold.
FSP silicon discards the request if the Voltage Regulator or SoC does not support the feature.
BUG:b:259057787 TEST:Verify that the feature is enabled by reading from pcode No PnP regression observed BRANCH=firmware-brya-14505.B
Signed-off-by: Jeremy Compostella jeremy.compostella@intel.com Change-Id: I7e318534f1429af8ec06048430966344ddd346a1 Reviewed-on: https://review.coreboot.org/c/coreboot/+/69579 Reviewed-by: Nick Vaccaro nvaccaro@google.com Reviewed-by: Cliff Huang cliff.huang@intel.com Reviewed-by: Jeremy Compostella jeremy.compostella@gmail.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/google/brya/variants/brya0/overridetree.cb M src/mainboard/google/brya/variants/skolas/overridetree.cb M src/mainboard/google/brya/variants/skolas4es/overridetree.cb 3 files changed, 38 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Jeremy Compostella: Looks good to me, but someone else must approve Nick Vaccaro: Looks good to me, approved Cliff Huang: Looks good to me, but someone else must approve Jérémy Compostella: Looks good to me, but someone else must approve
diff --git a/src/mainboard/google/brya/variants/brya0/overridetree.cb b/src/mainboard/google/brya/variants/brya0/overridetree.cb index 8decc06..1291f20 100644 --- a/src/mainboard/google/brya/variants/brya0/overridetree.cb +++ b/src/mainboard/google/brya/variants/brya0/overridetree.cb @@ -44,6 +44,10 @@ end
chip soc/intel/alderlake + register "domain_vr_config[VR_DOMAIN_IA]" = "{ + .enable_fast_vmode = 1, + }" + register "sagv" = "SaGv_Enabled"
register "platform_pmax" = "145" diff --git a/src/mainboard/google/brya/variants/skolas/overridetree.cb b/src/mainboard/google/brya/variants/skolas/overridetree.cb index fe60e90..0cecd14 100644 --- a/src/mainboard/google/brya/variants/skolas/overridetree.cb +++ b/src/mainboard/google/brya/variants/skolas/overridetree.cb @@ -44,6 +44,10 @@ end
chip soc/intel/alderlake + register "domain_vr_config[VR_DOMAIN_IA]" = "{ + .enable_fast_vmode = 1, + }" + register "sagv" = "SaGv_Enabled"
register "platform_pmax" = "145" diff --git a/src/mainboard/google/brya/variants/skolas4es/overridetree.cb b/src/mainboard/google/brya/variants/skolas4es/overridetree.cb index 1a91779..155be3d 100644 --- a/src/mainboard/google/brya/variants/skolas4es/overridetree.cb +++ b/src/mainboard/google/brya/variants/skolas4es/overridetree.cb @@ -40,6 +40,10 @@ end
chip soc/intel/alderlake + register "domain_vr_config[VR_DOMAIN_IA]" = "{ + .enable_fast_vmode = 1, + }" + register "sagv" = "SaGv_Enabled"
register "platform_pmax" = "145"