Attention is currently required from: Raul Rangel, Philipp Hug, Ron Minnich. Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59546 )
Change subject: arch/{arm,arm64,ppc64,riscv}: Add noop cpu_relax ......................................................................
Patch Set 1:
(2 comments)
File src/arch/arm/include/armv4/arch/cpu.h:
https://review.coreboot.org/c/coreboot/+/59546/comment/8183773d_860f8724 PS1, Line 6: __always_inline Just `inline` is enough. __always_inline is weird and shouldn't be used without good reason.
File src/arch/arm64/include/armv8/arch/cpu.h:
https://review.coreboot.org/c/coreboot/+/59546/comment/c505ce95_e0fc1398 PS1, Line 6: static __always_inline void cpu_relax(void) { } Maybe add a TODO comment that this should be implement via SEV/WFE if it's ever actually used?
-
Julius Werner (Code Review)