HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/46008 )
Change subject: mb/gigabyte/ga-945gcm-s2l: Convert *.asl to ASL 2.0 syntax ......................................................................
mb/gigabyte/ga-945gcm-s2l: Convert *.asl to ASL 2.0 syntax
Change-Id: Ic01ca9b58fe948fe5ffbc9e80ea4bae91fb6d581 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/mainboard/gigabyte/ga-945gcm-s2l/acpi/platform.asl M src/mainboard/gigabyte/ga-945gcm-s2l/acpi/superio.asl 2 files changed, 2 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/08/46008/1
diff --git a/src/mainboard/gigabyte/ga-945gcm-s2l/acpi/platform.asl b/src/mainboard/gigabyte/ga-945gcm-s2l/acpi/platform.asl index 30e4d2c..cf73fc1 100644 --- a/src/mainboard/gigabyte/ga-945gcm-s2l/acpi/platform.asl +++ b/src/mainboard/gigabyte/ga-945gcm-s2l/acpi/platform.asl @@ -20,12 +20,12 @@ // was inserted while a sleep state was active.
// Are we going to S3? - If (LEqual(Arg0, 3)) { + If (Arg0 == 3) { // .. }
// Are we going to S4? - If (LEqual(Arg0, 4)) { + If (Arg0 == 4) { // .. }
diff --git a/src/mainboard/gigabyte/ga-945gcm-s2l/acpi/superio.asl b/src/mainboard/gigabyte/ga-945gcm-s2l/acpi/superio.asl index 2997587..e69de29 100644 --- a/src/mainboard/gigabyte/ga-945gcm-s2l/acpi/superio.asl +++ b/src/mainboard/gigabyte/ga-945gcm-s2l/acpi/superio.asl @@ -1 +0,0 @@ -/* dummy */
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/46008
to look at the new patch set (#2).
Change subject: mb/gigabyte/ga-945gcm-s2l: Convert *.asl to ASL 2.0 syntax ......................................................................
mb/gigabyte/ga-945gcm-s2l: Convert *.asl to ASL 2.0 syntax
Also remove useless comment.
Change-Id: Ic01ca9b58fe948fe5ffbc9e80ea4bae91fb6d581 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/mainboard/gigabyte/ga-945gcm-s2l/acpi/platform.asl M src/mainboard/gigabyte/ga-945gcm-s2l/acpi/superio.asl 2 files changed, 2 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/08/46008/2
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/46008
to look at the new patch set (#3).
Change subject: mb/gigabyte/ga-945gcm-s2l: Convert *.asl to ASL 2.0 syntax ......................................................................
mb/gigabyte/ga-945gcm-s2l: Convert *.asl to ASL 2.0 syntax
Generated 'Build/dsdt.dsl' are identical.
Change-Id: Ic01ca9b58fe948fe5ffbc9e80ea4bae91fb6d581 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/mainboard/gigabyte/ga-945gcm-s2l/acpi/platform.asl 1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/08/46008/3
Attention is currently required from: HAOUAS Elyes. Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46008 )
Change subject: mb/gigabyte/ga-945gcm-s2l: Convert *.asl to ASL 2.0 syntax ......................................................................
Patch Set 3: Code-Review+2
Michael Niewöhner has submitted this change. ( https://review.coreboot.org/c/coreboot/+/46008 )
Change subject: mb/gigabyte/ga-945gcm-s2l: Convert *.asl to ASL 2.0 syntax ......................................................................
mb/gigabyte/ga-945gcm-s2l: Convert *.asl to ASL 2.0 syntax
Generated 'Build/dsdt.dsl' are identical.
Change-Id: Ic01ca9b58fe948fe5ffbc9e80ea4bae91fb6d581 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr Reviewed-on: https://review.coreboot.org/c/coreboot/+/46008 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Michael Niewöhner foss@mniewoehner.de --- M src/mainboard/gigabyte/ga-945gcm-s2l/acpi/platform.asl 1 file changed, 2 insertions(+), 2 deletions(-)
Approvals: build bot (Jenkins): Verified Michael Niewöhner: Looks good to me, approved
diff --git a/src/mainboard/gigabyte/ga-945gcm-s2l/acpi/platform.asl b/src/mainboard/gigabyte/ga-945gcm-s2l/acpi/platform.asl index 30e4d2c..cf73fc1 100644 --- a/src/mainboard/gigabyte/ga-945gcm-s2l/acpi/platform.asl +++ b/src/mainboard/gigabyte/ga-945gcm-s2l/acpi/platform.asl @@ -20,12 +20,12 @@ // was inserted while a sleep state was active.
// Are we going to S3? - If (LEqual(Arg0, 3)) { + If (Arg0 == 3) { // .. }
// Are we going to S4? - If (LEqual(Arg0, 4)) { + If (Arg0 == 4) { // .. }
-
HAOUAS Elyes (Code Review) -
Michael Niewöhner (Code Review)