Nico Huber has submitted this change and it was merged. ( https://review.coreboot.org/c/libgfxinit/+/27064 )
Change subject: gma pipe setup: Drop explicit Global and Depends contracts ......................................................................
gma pipe setup: Drop explicit Global and Depends contracts
These were originally only added to prevent proof inlining and are not needed any more.
Change-Id: Ia75c78a7030960a56e9cb469601b24c677732875 Signed-off-by: Nico Huber nico.h@gmx.de Reviewed-on: https://review.coreboot.org/c/libgfxinit/+/27064 Reviewed-by: Arthur Heymans arthur@aheymans.xyz --- M common/hw-gfx-gma-pipe_setup.adb 1 file changed, 0 insertions(+), 12 deletions(-)
Approvals: Nico Huber: Verified Arthur Heymans: Looks good to me, approved
diff --git a/common/hw-gfx-gma-pipe_setup.adb b/common/hw-gfx-gma-pipe_setup.adb index a237de7..76051dd 100644 --- a/common/hw-gfx-gma-pipe_setup.adb +++ b/common/hw-gfx-gma-pipe_setup.adb @@ -283,18 +283,6 @@ Dither_BPC : BPC_Type; Dither : Boolean) with - Global => (In_Out => (Registers.Register_State, Port_IO.State)), - Depends => - (Registers.Register_State - =>+ - (Registers.Register_State, - Controller, - Framebuffer, - Dither_BPC, - Dither), - Port_IO.State - =>+ - (Framebuffer)), Pre => Framebuffer.Offset = VGA_PLANE_FRAMEBUFFER_OFFSET or Framebuffer.Height + Framebuffer.Start_Y <= Framebuffer.V_Stride