Attention is currently required from: Kapil Porwal, Paul Menzel, Pranava Y N, Subrata Banik.
Jérémy Compostella has posted comments on this change by Jérémy Compostella. ( https://review.coreboot.org/c/coreboot/+/85131?usp=email )
Change subject: soc/intel/pantherlake: Bind SoC config VR settings to respective UPD
......................................................................
Patch Set 6:
(1 comment)
This change is ready for review.
File src/soc/intel/pantherlake/romstage/fsp_params.c:
https://review.coreboot.org/c/coreboot/+/85131/comment/058d75e6_3dea20f7?usp... :
PS6, Line 271: ARRAY_SIZE(config->enable_fast_vmode
nit: Can we use NUM_VR_DOMAINS macro directly here?
I have a couple of reasons to like doing it like this but the most important is
that it does not bind this code to a declared constant. Instead the compiler provides the size at compilation time avoid any de-synchronization between declaration and use.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/85131?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ie72e4725cb97b4af7843a43eeaedd687d28b6752
Gerrit-Change-Number: 85131
Gerrit-PatchSet: 6
Gerrit-Owner: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: Pranava Y N
pranavayn@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-CC: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Pranava Y N
pranavayn@google.com
Gerrit-Comment-Date: Wed, 18 Dec 2024 17:10:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Pranava Y N
pranavayn@google.com