[S] Change in coreboot[main]: mb/var/uldrenite: Configure descriptor for either MBVR or FIVR

[Jérémy Compostella (Code Review)]

Attention is currently required from: Ben Kao, Dinesh Gehlot, Dtrain Hsu, Intel coreboot Reviewers, Jamie Chen, Jayvik Desai, John Su, Kapil Porwal, Nick Vaccaro, Subrata Banik.

Jérémy Compostella has posted comments on this change by John Su. ( https://review.coreboot.org/c/coreboot/+/87033?usp=email )

Change subject: mb/var/uldrenite: Configure descriptor for either MBVR or FIVR
......................................................................

Patch Set 6:

(7 comments)

Commit Message:

https://review.coreboot.org/c/coreboot/+/87033/comment/79d133ed_dcb7ffeb?usp... :
PS6, Line 9: R(
nit: space

https://review.coreboot.org/c/coreboot/+/87033/comment/9cb91577_a15dcdd4?usp... :
PS6, Line 10: (
nit: space

File src/mainboard/google/brya/variants/uldrenite/variant.c:

https://review.coreboot.org/c/coreboot/+/87033/comment/607db58b_95f12593?usp... :
PS6, Line 3: #include <baseboard/gpio.h>
           : #include <baseboard/variants.h>
           : #include <console/console.h>
           : #include <delay.h>
           : #include <fw_config.h>
           : #include <sar.h>
           : #include <soc/bootblock.h>
           : #include <boardid.h>
nit: Not a strong rule, but usually headers are alphabetically sorted. It seems it was before your change, so I would recommend you do the same.

https://review.coreboot.org/c/coreboot/+/87033/comment/d94d3f3b_1199c5ab?usp... :
PS6, Line 85: .*
space

https://review.coreboot.org/c/coreboot/+/87033/comment/28ff8b87_fb403f3e?usp... :
PS6, Line 91: }
space

https://review.coreboot.org/c/coreboot/+/87033/comment/5882d928_8d1dd57c?usp... :
PS6, Line 96: }
space

File src/soc/intel/alderlake/bootblock/update_descriptor.c:

https://review.coreboot.org/c/coreboot/+/87033/comment/f1def584_2aafa9f8?usp... :
PS6, Line 26: if (read32p((uintptr_t)(desc + FLASH_SIGN_OFFSET)) != FLASH_VAL_SIGN) {
            : 		printk(BIOS_ERR, "Flash Descriptor is not valid\n");
            : 		return false;
            : 	}
            : 
            : 	/* Check host has write access to the Descriptor Region */
            : 	if (!((read32p((uintptr_t)(desc + FLMSTR1)) >> FLMSTR_WR_SHIFT_V2) & BIT(0))) {
            : 		printk(BIOS_ERR, "Host doesn't have write access to Descriptor Region\n");
            : 		return false;
            : 	}
Why is this necessary?