Matt DeVillier has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/40595 )
Change subject: mb/google/octopus: Add VBT for ampton variant ......................................................................
mb/google/octopus: Add VBT for ampton variant
Add VBT file, extracted from stock Google firmware, and select its use via Kconfig.
Change-Id: I256c1c72d1d1e40ea9426fa717bfc4f9c950a91f Signed-off-by: Matt DeVillier matt.devillier@gmail.com --- M src/mainboard/google/octopus/Kconfig A src/mainboard/google/octopus/variants/ampton/data.vbt 2 files changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/95/40595/1
diff --git a/src/mainboard/google/octopus/Kconfig b/src/mainboard/google/octopus/Kconfig index e52e994..01e9f9f 100644 --- a/src/mainboard/google/octopus/Kconfig +++ b/src/mainboard/google/octopus/Kconfig @@ -17,6 +17,7 @@ select EC_GOOGLE_CHROMEEC_ESPI select HAVE_ACPI_RESUME select HAVE_ACPI_TABLES + select INTEL_GMA_HAVE_VBT if BOARD_GOOGLE_AMPTON select INTEL_LPSS_UART_FOR_CONSOLE select MAINBOARD_HAS_CHROMEOS select SOC_ESPI diff --git a/src/mainboard/google/octopus/variants/ampton/data.vbt b/src/mainboard/google/octopus/variants/ampton/data.vbt new file mode 100644 index 0000000..88ae386 --- /dev/null +++ b/src/mainboard/google/octopus/variants/ampton/data.vbt Binary files differ
Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40595 )
Change subject: mb/google/octopus: Add VBT for ampton variant ......................................................................
Patch Set 1: Code-Review+2
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40595 )
Change subject: mb/google/octopus: Add VBT for ampton variant ......................................................................
Patch Set 1: Code-Review+2
Matt DeVillier has submitted this change. ( https://review.coreboot.org/c/coreboot/+/40595 )
Change subject: mb/google/octopus: Add VBT for ampton variant ......................................................................
mb/google/octopus: Add VBT for ampton variant
Add VBT file, extracted from stock Google firmware, and select its use via Kconfig.
Change-Id: I256c1c72d1d1e40ea9426fa717bfc4f9c950a91f Signed-off-by: Matt DeVillier matt.devillier@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/40595 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Patrick Rudolph siro@das-labor.org Reviewed-by: Angel Pons th3fanbus@gmail.com --- M src/mainboard/google/octopus/Kconfig A src/mainboard/google/octopus/variants/ampton/data.vbt 2 files changed, 1 insertion(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Patrick Rudolph: Looks good to me, approved Angel Pons: Looks good to me, approved
diff --git a/src/mainboard/google/octopus/Kconfig b/src/mainboard/google/octopus/Kconfig index e52e994..01e9f9f 100644 --- a/src/mainboard/google/octopus/Kconfig +++ b/src/mainboard/google/octopus/Kconfig @@ -17,6 +17,7 @@ select EC_GOOGLE_CHROMEEC_ESPI select HAVE_ACPI_RESUME select HAVE_ACPI_TABLES + select INTEL_GMA_HAVE_VBT if BOARD_GOOGLE_AMPTON select INTEL_LPSS_UART_FOR_CONSOLE select MAINBOARD_HAS_CHROMEOS select SOC_ESPI diff --git a/src/mainboard/google/octopus/variants/ampton/data.vbt b/src/mainboard/google/octopus/variants/ampton/data.vbt new file mode 100644 index 0000000..88ae386 --- /dev/null +++ b/src/mainboard/google/octopus/variants/ampton/data.vbt Binary files differ
-
Angel Pons (Code Review) -
Matt DeVillier (Code Review)
-
Patrick Rudolph (Code Review)