Attention is currently required from: Sean Rhodes, Martin Roth, Tim Wawrzynczak, Angel Pons. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58854 )
Change subject: [WIP] util: Add coreboot Configurator ......................................................................
Patch Set 18:
(363 comments)
File util/coreboot-configurator/src/Documentation.txt:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/67610e79_c1967b96 PS18, Line 5: This allows `coreboot-configurator` to display them in a relavant tab, with a nice 'relavant' may be misspelled - perhaps 'relevant'?
File util/coreboot-configurator/src/application/aboutwindow.h:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/ff424c8b_c32a3a28 PS18, Line 16: public: spaces required around that ':' (ctx:VxE)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/9d041fb9_100b1f3c PS18, Line 17: explicit aboutWindow(QWidget *parent = nullptr); need consistent spacing around '*' (ctx:WxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/a13e8886_36d832a4 PS18, Line 21: Ui::aboutWindow *ui; need consistent spacing around '*' (ctx:WxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/fad83149_43d44e2b PS18, Line 21: Ui::aboutWindow *ui; labels should not be indented
File util/coreboot-configurator/src/application/configuration.h:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/cff05ad6_75a4d3a8 PS18, Line 13: QMap<QString,QString> fromFile(const QString& curr_path); spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/3aaf693f_29a2f0a3 PS18, Line 13: QMap<QString,QString> fromFile(const QString& curr_path); space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/df3d5702_6009cd10 PS18, Line 13: QMap<QString,QString> fromFile(const QString& curr_path); spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/9594e2f5_04f8dee5 PS18, Line 13: QMap<QString,QString> fromFile(const QString& curr_path); need consistent spacing around '&' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/1d2ed6e3_ee3b1d62 PS18, Line 15: QMap<QString,QString> fromNvramTool(); spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/aab6f8e3_8bae2001 PS18, Line 15: QMap<QString,QString> fromNvramTool(); space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/1199d4ea_15526077 PS18, Line 15: QMap<QString,QString> fromNvramTool(); spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/32de4057_6ceb31e9 PS18, Line 17: QMap<QString,QString> mocked(); spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/ccfe89ca_b8a2de19 PS18, Line 17: QMap<QString,QString> mocked(); space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/36e6aa78_5efd40b6 PS18, Line 17: QMap<QString,QString> mocked(); spaces required around that '>' (ctx:VxW)
File util/coreboot-configurator/src/application/coreboot_configurator.h:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/f7adafe8_c660b06c PS18, Line 29: public: spaces required around that ':' (ctx:VxE)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/bc0013d0_4e5a55a1 PS18, Line 30: coreboot_configurator(QWidget *parent = nullptr); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/c0a8ca73_34fcfcdc PS18, Line 30: coreboot_configurator(QWidget *parent = nullptr); need consistent spacing around '*' (ctx:WxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/51f58a21_fb9b11c8 PS18, Line 37: void showEvent(QShowEvent *ev); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/d4c2ed34_d28ad1a5 PS18, Line 37: void showEvent(QShowEvent *ev); need consistent spacing around '*' (ctx:WxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/5a089be4_88277215 PS18, Line 38: void closeEvent(QCloseEvent *ev); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/0fd343b9_833f28a9 PS18, Line 42: void closeWindow(int result); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/f02834f8_55206472 PS18, Line 43: void saveAndClose(void); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/488ff046_9b5699cf PS18, Line 46: void getSettings(void); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/efd58864_26da3c1b PS18, Line 47: void getFromFile(void); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/728cecde_ed856dc3 PS18, Line 48: void displaySettings(); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/bb92b59a_0864ae38 PS18, Line 48: void displaySettings(); Bad function definition - void displaySettings() should probably be void displaySettings(void)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/c14df4f0_279f88e4 PS18, Line 51: void writeSettings(void); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/2e868e50_1b848ea3 PS18, Line 52: void writeToFile(const QString& out_file); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/faec4b14_5d80970c PS18, Line 52: void writeToFile(const QString& out_file); need consistent spacing around '&' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/abc888ec_79c75efb PS18, Line 55: void updateValue(const QString& name); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/af621226_549f6601 PS18, Line 55: void updateValue(const QString& name); need consistent spacing around '&' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/8e4d62a2_f92242be PS18, Line 59: QString m_fileName; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/b6d85b1d_d7e51bad PS18, Line 61: QMap<QString, QString> m_values; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/e07f2d0a_819e6d4e PS18, Line 61: QMap<QString, QString> m_values; spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/cb0d1639_e1caeb93 PS18, Line 61: QMap<QString, QString> m_values; spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/8ad343a2_a3900684 PS18, Line 64: QMap<QString, QVBoxLayout*> m_tabs; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/02c300ea_d790bbad PS18, Line 64: QMap<QString, QVBoxLayout*> m_tabs; spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/f4680ef4_7b3fcaf8 PS18, Line 64: QMap<QString, QVBoxLayout*> m_tabs; spaces required around that '>' (ctx:OxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/b86b1ec1_4efb5498 PS18, Line 67: YAML::Node m_categories; labels should not be indented
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/a3916c84_1cb2a25c PS18, Line 70: QComboBox *textToDisplay(const QString &in_string); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/c74f84f7_f31cbe35 PS18, Line 70: QComboBox *textToDisplay(const QString &in_string); need consistent spacing around '&' (ctx:WxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/997270f5_d70154ee PS18, Line 71: QCheckBox *checkToDisplay(const QString &in_string); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/bb47acf7_2a152cd2 PS18, Line 71: QCheckBox *checkToDisplay(const QString &in_string); need consistent spacing around '&' (ctx:WxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/6c8e75b0_8c5f75ce PS18, Line 73: Ui::coreboot_configurator *ui; need consistent spacing around '*' (ctx:WxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/74569a79_76ce3b82 PS18, Line 73: Ui::coreboot_configurator *ui; labels should not be indented
File util/coreboot-configurator/src/application/qtyaml.h:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/46ef2350_2095f948 PS18, Line 17: template<> spaces required around that '<' (ctx:VxO)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/85db086b_5ef69ccd PS18, Line 17: template<> spaces required around that '>' (ctx:OxE)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/52f634a4_12c8e8a2 PS18, Line 18: struct convert<QString> spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/fe2baa73_7941499f PS18, Line 18: struct convert<QString> spaces required around that '>' (ctx:VxE)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/4b663e88_4d700897 PS18, Line 20: static Node encode(const QString& rhs) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/65a935c0_a9300806 PS18, Line 20: static Node encode(const QString& rhs) need consistent spacing around '&' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/979680f8_5d882987 PS18, Line 20: static Node encode(const QString& rhs) open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/177fefea_d0db6b53 PS18, Line 21: { please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/4cc843d1_21ef3bc9 PS18, Line 22: return Node(rhs.toStdString()); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/e8238bcf_379feeae PS18, Line 22: return Node(rhs.toStdString()); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/a1694f6f_c575479b PS18, Line 23: } please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/14b5cb27_4c87dfa0 PS18, Line 25: static bool decode(const Node& node, QString& rhs) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/4d610b3c_2e211b95 PS18, Line 25: static bool decode(const Node& node, QString& rhs) need consistent spacing around '&' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/0836661c_2338b4eb PS18, Line 25: static bool decode(const Node& node, QString& rhs) need consistent spacing around '&' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/7589a158_1b5e1653 PS18, Line 25: static bool decode(const Node& node, QString& rhs) open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/53bc738b_b7073c21 PS18, Line 26: { please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/f66b1ae0_049e02cd PS18, Line 27: if (!node.IsScalar()) code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/09b6f31c_57fa694b PS18, Line 27: if (!node.IsScalar()) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/7d009938_d21225e4 PS18, Line 27: if (!node.IsScalar()) suspect code indent for conditional statements (8, 12)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/ee144fa2_d992b0e9 PS18, Line 28: return false; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/6bd36905_3fc7b4e0 PS18, Line 28: return false; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/aa0eb3d0_01275cd7 PS18, Line 29: rhs = QString::fromStdString(node.Scalar()); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/2584a766_907b2fa9 PS18, Line 29: rhs = QString::fromStdString(node.Scalar()); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/2386e3b8_a6ed163b PS18, Line 30: return true; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/6da97ff1_efaa3886 PS18, Line 30: return true; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/9b96185b_fe4a68aa PS18, Line 31: } please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/2f1428bb_6ea83b48 PS18, Line 35: template<typename Key, typename Value> spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/68c0200d_a56542cb PS18, Line 35: template<typename Key, typename Value> spaces required around that '>' (ctx:VxE)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/7fd5926b_80305681 PS18, Line 36: struct convert<QMap<Key, Value> > spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/15f4d4a2_8c10bc53 PS18, Line 36: struct convert<QMap<Key, Value> > spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/f393c2cf_62233325 PS18, Line 36: struct convert<QMap<Key, Value> > spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/579f6a44_a6634739 PS18, Line 38: static Node encode(const QMap<Key,Value>& rhs) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/c4156aab_b79d609a PS18, Line 38: static Node encode(const QMap<Key,Value>& rhs) spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/5b3f06c7_5e8c351f PS18, Line 38: static Node encode(const QMap<Key,Value>& rhs) space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/3a6c6c3a_522681e8 PS18, Line 38: static Node encode(const QMap<Key,Value>& rhs) spaces required around that '>' (ctx:VxO)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/f4a92ed8_3ee98dc5 PS18, Line 38: static Node encode(const QMap<Key,Value>& rhs) space required before that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/ce529e34_dd344d89 PS18, Line 38: static Node encode(const QMap<Key,Value>& rhs) space prohibited after that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/fff6f3db_bf32c58f PS18, Line 38: static Node encode(const QMap<Key,Value>& rhs) open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/17a639a7_1c9e19e1 PS18, Line 39: { please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/28048744_5d51996e PS18, Line 40: Node node(NodeType::Map); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/acacb841_aa8a9bf2 PS18, Line 40: Node node(NodeType::Map); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/fd046516_2142ae16 PS18, Line 41: auto it = rhs.constBegin(); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/8eb9fbd8_9efc2b32 PS18, Line 41: auto it = rhs.constBegin(); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/ef9605ea_715a5397 PS18, Line 42: while (it != rhs.constEnd()) code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/e7e40fad_59a3182f PS18, Line 42: while (it != rhs.constEnd()) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/c7c87e73_757388b0 PS18, Line 42: while (it != rhs.constEnd()) that open brace { should be on the previous line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/f63ff7ac_860216ec PS18, Line 42: while (it != rhs.constEnd()) suspect code indent for conditional statements (8, 12)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/556a0801_286e45eb PS18, Line 43: { code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/f957eccc_18e02ebf PS18, Line 43: { please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/89cd58aa_7d98d4fb PS18, Line 44: node.force_insert(it.key(), it.value()); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/0dd18327_202d14ea PS18, Line 44: node.force_insert(it.key(), it.value()); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/6e9c3a05_914acde6 PS18, Line 45: ++it; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/f074959b_69b5e169 PS18, Line 45: ++it; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/28990bcf_b45cf609 PS18, Line 46: } code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/1c5dc09f_9a39fa0e PS18, Line 46: } please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/8163b967_d1bbd129 PS18, Line 47: return node; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/cced4ba5_2a759108 PS18, Line 47: return node; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/42d2061a_af4a57ba PS18, Line 48: } please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/da1e1b68_d679550a PS18, Line 50: static bool decode(const Node& node, QMap<Key, Value>& rhs) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/2d11f22e_8a5eab49 PS18, Line 50: static bool decode(const Node& node, QMap<Key, Value>& rhs) need consistent spacing around '&' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/ef490e21_fe71c6c2 PS18, Line 50: static bool decode(const Node& node, QMap<Key, Value>& rhs) spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/69f50b9f_14ba2182 PS18, Line 50: static bool decode(const Node& node, QMap<Key, Value>& rhs) spaces required around that '>' (ctx:VxO)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/8b6d28ca_ea1625b2 PS18, Line 50: static bool decode(const Node& node, QMap<Key, Value>& rhs) space required before that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/e0172713_fe536e1b PS18, Line 50: static bool decode(const Node& node, QMap<Key, Value>& rhs) space prohibited after that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/d6cfc298_3acd3fac PS18, Line 50: static bool decode(const Node& node, QMap<Key, Value>& rhs) open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/ef129480_f299fc5e PS18, Line 51: { please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/4d6673b3_2f3a958f PS18, Line 52: if (!node.IsMap()) code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/563005d5_61f8f012 PS18, Line 52: if (!node.IsMap()) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/7d780f03_3270ec25 PS18, Line 52: if (!node.IsMap()) suspect code indent for conditional statements (8, 12)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/5f093af9_0e5ad841 PS18, Line 53: return false; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/060b6f44_e63a6d3b PS18, Line 53: return false; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/7b0e89c3_a904bf0e PS18, Line 55: rhs.clear(); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/b748050c_c1667107 PS18, Line 55: rhs.clear(); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/2af4dfc6_3ce809f2 PS18, Line 56: const_iterator it = node.begin(); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/31496571_8980cc5b PS18, Line 56: const_iterator it = node.begin(); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/82f0238e_7215c79e PS18, Line 57: while (it != node.end()) code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/0178921e_979d5a0d PS18, Line 57: while (it != node.end()) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/ca91f5b3_f4bedbf2 PS18, Line 57: while (it != node.end()) that open brace { should be on the previous line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/853e4094_bdeffc66 PS18, Line 57: while (it != node.end()) suspect code indent for conditional statements (8, 12)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/3ac67f1e_a94961c7 PS18, Line 58: { code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/8f7abd88_ff0dbc4a PS18, Line 58: { please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/4f9950e6_46f6c79f PS18, Line 59: rhs[it->first.as<Key>()] = it->second.as<Value>(); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/d4794c17_6a46ecd1 PS18, Line 59: rhs[it->first.as<Key>()] = it->second.as<Value>(); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/4a7cee86_0e18e209 PS18, Line 59: rhs[it->first.as<Key>()] = it->second.as<Value>(); spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/65866707_c5a5446b PS18, Line 59: rhs[it->first.as<Key>()] = it->second.as<Value>(); spaces required around that '>' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/ff67fa64_7c754a72 PS18, Line 59: rhs[it->first.as<Key>()] = it->second.as<Value>(); spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/387a98a9_faf73207 PS18, Line 59: rhs[it->first.as<Key>()] = it->second.as<Value>(); spaces required around that '>' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/edd9c1a1_5796d350 PS18, Line 60: ++it; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/9c601da1_dce14e12 PS18, Line 60: ++it; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/fecace56_fd259af9 PS18, Line 61: } code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/32fa17c7_433fc7e0 PS18, Line 61: } please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/3f4241b9_2ed2228c PS18, Line 62: return true; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/08653d7c_83adc85a PS18, Line 62: return true; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/4d33b682_bd7ae215 PS18, Line 63: } please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/dc35fed4_6c4b6468 PS18, Line 67: template<typename T> spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/03097e32_760a2e31 PS18, Line 67: template<typename T> spaces required around that '>' (ctx:VxE)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/3aa1aeef_11ec3699 PS18, Line 68: struct convert<QVector<T> > spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/293d55d9_20cf2b27 PS18, Line 68: struct convert<QVector<T> > spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/9ed7528a_ee1eddaa PS18, Line 68: struct convert<QVector<T> > spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/f64c4d77_e05f9792 PS18, Line 70: static Node encode(const QVector<T>& rhs) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/7be1e9e2_54bf16a9 PS18, Line 70: static Node encode(const QVector<T>& rhs) spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/ecde5df6_a352908b PS18, Line 70: static Node encode(const QVector<T>& rhs) spaces required around that '>' (ctx:VxO)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/a4f332f5_d1d622be PS18, Line 70: static Node encode(const QVector<T>& rhs) space required before that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/9d643979_7488a686 PS18, Line 70: static Node encode(const QVector<T>& rhs) space prohibited after that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/e3e2adae_44fdfd66 PS18, Line 70: static Node encode(const QVector<T>& rhs) open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/d069596a_d09cd33f PS18, Line 71: { please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/8b74d08f_7583d5f5 PS18, Line 72: Node node(NodeType::Sequence); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/ce3443bd_b0e83cd2 PS18, Line 72: Node node(NodeType::Sequence); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/4bc23783_193b35c4 PS18, Line 73: foreach (T value, rhs) { code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/185f1623_8481857c PS18, Line 73: foreach (T value, rhs) { please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/6a077c35_d9b94bfe PS18, Line 73: foreach (T value, rhs) { space prohibited between function name and open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/6a37e3b8_afee23c2 PS18, Line 74: node.push_back(value); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/ae8a0178_a4944cda PS18, Line 74: node.push_back(value); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/040d4eb9_be2c6446 PS18, Line 75: } code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/9abc6bfc_55a2517d PS18, Line 75: } please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/db576afc_7e194deb PS18, Line 76: return node; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/840c0436_2c60c4f5 PS18, Line 76: return node; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/60205b59_6c4350de PS18, Line 77: } please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/6fb26953_f7612263 PS18, Line 79: static bool decode(const Node& node, QVector<T>& rhs) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/5f724b13_0e1b1176 PS18, Line 79: static bool decode(const Node& node, QVector<T>& rhs) need consistent spacing around '&' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/e2a0cf28_02ab8885 PS18, Line 79: static bool decode(const Node& node, QVector<T>& rhs) spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/713b3f67_ca33d928 PS18, Line 79: static bool decode(const Node& node, QVector<T>& rhs) spaces required around that '>' (ctx:VxO)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/c450d5b0_00abcf59 PS18, Line 79: static bool decode(const Node& node, QVector<T>& rhs) space required before that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/35c83d8a_2b77b08d PS18, Line 79: static bool decode(const Node& node, QVector<T>& rhs) space prohibited after that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/a214e766_1f380e84 PS18, Line 79: static bool decode(const Node& node, QVector<T>& rhs) open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/3c16895d_13a165cf PS18, Line 80: { please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/7db4370c_35bd0a64 PS18, Line 81: if (!node.IsSequence()) code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/53ed0b27_4fa58ee8 PS18, Line 81: if (!node.IsSequence()) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/370342c5_25a441e4 PS18, Line 81: if (!node.IsSequence()) suspect code indent for conditional statements (8, 12)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/81f4ae44_819627c8 PS18, Line 82: return false; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/4fcebab9_0155bf30 PS18, Line 82: return false; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/9ba0102c_b07341e4 PS18, Line 84: rhs.clear(); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/76cf2e17_3b34ea04 PS18, Line 84: rhs.clear(); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/03e32853_191629f7 PS18, Line 85: const_iterator it = node.begin(); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/a2ad7e24_bbe93f9e PS18, Line 85: const_iterator it = node.begin(); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/32849343_0a94754e PS18, Line 86: while (it != node.end()) code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/9a866e2a_d670d8fa PS18, Line 86: while (it != node.end()) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/5913027e_7e84b10c PS18, Line 86: while (it != node.end()) that open brace { should be on the previous line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/c104ad71_692a144b PS18, Line 86: while (it != node.end()) suspect code indent for conditional statements (8, 12)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/8d360921_bef6fd08 PS18, Line 87: { code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/32f85fda_476fb517 PS18, Line 87: { please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/84d848f7_b3a449ac PS18, Line 88: rhs.push_back(it->as<T>()); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/ecd1fd0a_0586eb8a PS18, Line 88: rhs.push_back(it->as<T>()); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/81a6b779_0ab5a35c PS18, Line 88: rhs.push_back(it->as<T>()); spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/63d79759_d7b7e8fd PS18, Line 88: rhs.push_back(it->as<T>()); spaces required around that '>' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/86ac1c8b_50dd6a0f PS18, Line 89: ++it; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/ac7a41ff_1ff85d6d PS18, Line 89: ++it; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/7b14d89b_00bea572 PS18, Line 90: } code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/ffab223f_4c71df88 PS18, Line 90: } please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/9f9367f5_c7a1664e PS18, Line 91: return true; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/76a10274_71b514a2 PS18, Line 91: return true; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/ff1fd083_08512275 PS18, Line 92: } please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/3446c089_8f4dee31 PS18, Line 96: template<typename T> spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/8f94faba_5f2f3c6e PS18, Line 96: template<typename T> spaces required around that '>' (ctx:VxE)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/59c285ac_34f3004a PS18, Line 97: struct convert<QList<T> > spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/1ac5e6c1_e248c322 PS18, Line 97: struct convert<QList<T> > spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/b057cd17_18abd7d4 PS18, Line 97: struct convert<QList<T> > spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/ee4a8ba9_5c969b20 PS18, Line 99: static Node encode(const QList<T>& rhs) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/f9d1863b_857815f2 PS18, Line 99: static Node encode(const QList<T>& rhs) spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/10d957a6_4596fe69 PS18, Line 99: static Node encode(const QList<T>& rhs) spaces required around that '>' (ctx:VxO)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/2d3c4aeb_df8a216b PS18, Line 99: static Node encode(const QList<T>& rhs) space required before that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/eeb901dc_f4dedb40 PS18, Line 99: static Node encode(const QList<T>& rhs) space prohibited after that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/b244c023_f3b4cf26 PS18, Line 99: static Node encode(const QList<T>& rhs) open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/184720af_539af6d4 PS18, Line 100: { please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/321b63a8_d65077de PS18, Line 101: Node node(NodeType::Sequence); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/92df22e5_b4e2da9b PS18, Line 101: Node node(NodeType::Sequence); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/3667fa53_354c17f3 PS18, Line 102: foreach (T value, rhs) { code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/2936da79_0e0b23ed PS18, Line 102: foreach (T value, rhs) { please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/caededcb_60ea0f75 PS18, Line 102: foreach (T value, rhs) { space prohibited between function name and open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/9fc161dc_c77a43af PS18, Line 103: node.push_back(value); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/4292c007_8a571d30 PS18, Line 103: node.push_back(value); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/791203c8_7252d4bd PS18, Line 104: } code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/56bca7da_1b76894b PS18, Line 104: } please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/d0bb225b_a0b16491 PS18, Line 105: return node; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/d2123318_10f4de64 PS18, Line 105: return node; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/481e1c8c_60980286 PS18, Line 106: } please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/93610a15_b930367c PS18, Line 108: static bool decode(const Node& node, QList<T>& rhs) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/0fa7362f_bf5da725 PS18, Line 108: static bool decode(const Node& node, QList<T>& rhs) need consistent spacing around '&' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/dd95eee3_899ae74d PS18, Line 108: static bool decode(const Node& node, QList<T>& rhs) spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/01817f2c_938125ee PS18, Line 108: static bool decode(const Node& node, QList<T>& rhs) spaces required around that '>' (ctx:VxO)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/74b60bec_f26d0263 PS18, Line 108: static bool decode(const Node& node, QList<T>& rhs) space required before that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/bd837144_855f0970 PS18, Line 108: static bool decode(const Node& node, QList<T>& rhs) space prohibited after that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/a30bcb51_3da92b97 PS18, Line 108: static bool decode(const Node& node, QList<T>& rhs) open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/5d51ee37_869723b7 PS18, Line 109: { please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/be592b35_7e1def36 PS18, Line 110: if (!node.IsSequence()) code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/0785e3d0_13cf2f7b PS18, Line 110: if (!node.IsSequence()) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/ab1ce4e4_30dbfb79 PS18, Line 110: if (!node.IsSequence()) suspect code indent for conditional statements (8, 12)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/9edfb12f_685fd324 PS18, Line 111: return false; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/81e0ce2b_ce396193 PS18, Line 111: return false; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/2fefb496_284fdeb8 PS18, Line 113: rhs.clear(); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/b83aa4f9_a22fa600 PS18, Line 113: rhs.clear(); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/de33ae08_b72bb476 PS18, Line 114: const_iterator it = node.begin(); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/01281864_8ac701a7 PS18, Line 114: const_iterator it = node.begin(); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/41bb6d48_27eb3617 PS18, Line 115: while (it != node.end()) code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/97f9a178_666541de PS18, Line 115: while (it != node.end()) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/bc14f9d5_d668891b PS18, Line 115: while (it != node.end()) that open brace { should be on the previous line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/db318032_4b80942f PS18, Line 115: while (it != node.end()) suspect code indent for conditional statements (8, 12)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/fc8a53a9_b73b6cb8 PS18, Line 116: { code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/a9d1c952_09d47062 PS18, Line 116: { please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/c0d82b75_b7c5f698 PS18, Line 117: rhs.push_back(it->as<T>()); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/7896f5b4_6215938c PS18, Line 117: rhs.push_back(it->as<T>()); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/9e0e8f2d_e9f475cf PS18, Line 117: rhs.push_back(it->as<T>()); spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/8be51cfa_d486730e PS18, Line 117: rhs.push_back(it->as<T>()); spaces required around that '>' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/34669606_af1ecd3f PS18, Line 118: ++it; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/4b63ded4_8fbce494 PS18, Line 118: ++it; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/85a524e3_06c32c84 PS18, Line 119: } code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/a0ecc92f_b5078a29 PS18, Line 119: } please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/b21dbade_5aa64859 PS18, Line 120: return true; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/eddd678b_82ba3be8 PS18, Line 120: return true; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/6d2872b5_cb44449e PS18, Line 121: } please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/540f10ba_66c1aa44 PS18, Line 125: template<typename T, typename U> spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/2b368a66_6b2af40d PS18, Line 125: template<typename T, typename U> spaces required around that '>' (ctx:VxE)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/89ca37e9_7ea105d1 PS18, Line 126: struct convert<QPair<T,U> > spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/38c66153_26651025 PS18, Line 126: struct convert<QPair<T,U> > spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/01652117_d4a687ea PS18, Line 126: struct convert<QPair<T,U> > space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/43b0330b_003bc2a1 PS18, Line 126: struct convert<QPair<T,U> > spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/87d7f2c5_3d3112c9 PS18, Line 128: static Node encode(const QPair<T,U>& rhs) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/c12d69e6_3d07b88f PS18, Line 128: static Node encode(const QPair<T,U>& rhs) spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/aed168f6_111b215f PS18, Line 128: static Node encode(const QPair<T,U>& rhs) space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/6e0f61bf_6d73e80e PS18, Line 128: static Node encode(const QPair<T,U>& rhs) spaces required around that '>' (ctx:VxO)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/55e61d9a_590d275d PS18, Line 128: static Node encode(const QPair<T,U>& rhs) space required before that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/8e44f1f3_eb477216 PS18, Line 128: static Node encode(const QPair<T,U>& rhs) space prohibited after that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/4bec29a7_2d65d829 PS18, Line 128: static Node encode(const QPair<T,U>& rhs) open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/fb3bea5b_e458a5c5 PS18, Line 129: { please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/b9008825_36bb3cfb PS18, Line 130: Node node(NodeType::Sequence); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/c1110bcf_60c38132 PS18, Line 130: Node node(NodeType::Sequence); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/8957ce73_d934deac PS18, Line 131: node.push_back(rhs.first); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/ebb692e9_b9de0fc6 PS18, Line 131: node.push_back(rhs.first); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/13c88f60_50f70ac7 PS18, Line 132: node.push_back(rhs.second); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/dc06136c_a0c6f4e0 PS18, Line 132: node.push_back(rhs.second); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/ea777d4b_b3b913d6 PS18, Line 133: return node; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/92c3c533_fbde45a1 PS18, Line 133: return node; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/3de710eb_d25ff247 PS18, Line 134: } please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/ca5bf938_6ebd5970 PS18, Line 136: static bool decode(const Node& node, QPair<T,U>& rhs) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/b359414d_e24644c4 PS18, Line 136: static bool decode(const Node& node, QPair<T,U>& rhs) need consistent spacing around '&' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/51b835f0_2f5a4b82 PS18, Line 136: static bool decode(const Node& node, QPair<T,U>& rhs) spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/0370f693_727a556c PS18, Line 136: static bool decode(const Node& node, QPair<T,U>& rhs) space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/872fdeac_14e157f0 PS18, Line 136: static bool decode(const Node& node, QPair<T,U>& rhs) spaces required around that '>' (ctx:VxO)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/924bb73e_782a7a6e PS18, Line 136: static bool decode(const Node& node, QPair<T,U>& rhs) space required before that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/197cabc9_178de977 PS18, Line 136: static bool decode(const Node& node, QPair<T,U>& rhs) space prohibited after that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/d2200f52_ca69e3b9 PS18, Line 136: static bool decode(const Node& node, QPair<T,U>& rhs) open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/83759662_9ef59787 PS18, Line 137: { please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/14930287_c3df266c PS18, Line 138: if (!node.IsSequence()) code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/59222551_176edd34 PS18, Line 138: if (!node.IsSequence()) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/f9f3a17e_9e3054dd PS18, Line 138: if (!node.IsSequence()) suspect code indent for conditional statements (8, 12)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/35519de5_cf32ae0b PS18, Line 139: return false; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/6fb9f456_85d55fdd PS18, Line 139: return false; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/526b5039_0029c740 PS18, Line 140: if (node.size() != 2) code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/4e3c2634_3d8ce788 PS18, Line 140: if (node.size() != 2) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/22e936e2_7cd90f4f PS18, Line 140: if (node.size() != 2) suspect code indent for conditional statements (8, 12)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/2cee7416_8d3cf30c PS18, Line 141: return false; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/53affa18_09148a78 PS18, Line 141: return false; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/090ea2fe_77240ded PS18, Line 143: rhs.first = node[0].as<T>(); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/f3f2d0b2_00d18c1a PS18, Line 143: rhs.first = node[0].as<T>(); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/484498d5_bffe0058 PS18, Line 143: rhs.first = node[0].as<T>(); spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/7143f49d_6d31309c PS18, Line 143: rhs.first = node[0].as<T>(); spaces required around that '>' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/e10e9be0_50d34b87 PS18, Line 144: rhs.second = node[1].as<U>(); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/f74199ab_41e6afe3 PS18, Line 144: rhs.second = node[1].as<U>(); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/1c955937_675a8c3e PS18, Line 144: rhs.second = node[1].as<U>(); spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/a479aa03_69ac2924 PS18, Line 144: rhs.second = node[1].as<U>(); spaces required around that '>' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/dfea659e_6e8a2768 PS18, Line 145: return true; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/1d224564_052c3eb9 PS18, Line 145: return true; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/e1746f60_b64fe7c1 PS18, Line 146: } please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/6cebb0e5_01817fed PS18, Line 150: template<> spaces required around that '<' (ctx:VxO)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/e43b8830_5e417605 PS18, Line 150: template<> spaces required around that '>' (ctx:OxE)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/9f07a948_e143461f PS18, Line 151: struct convert<QStringList> spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/64f7651a_18301797 PS18, Line 151: struct convert<QStringList> spaces required around that '>' (ctx:VxE)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/4046c320_795d8d8f PS18, Line 153: static Node encode(const QStringList& rhs) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/88701038_4aefeec7 PS18, Line 153: static Node encode(const QStringList& rhs) need consistent spacing around '&' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/7c1bdd68_37b939c0 PS18, Line 153: static Node encode(const QStringList& rhs) open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/a7fc4667_6dde655b PS18, Line 154: { please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/018a3a4d_6f652673 PS18, Line 155: Node node(NodeType::Sequence); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/2aa9e876_4bce82a7 PS18, Line 155: Node node(NodeType::Sequence); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/146782ae_47c0ce05 PS18, Line 156: for (const auto &value: rhs) { code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/6e493e3a_b6e97904 PS18, Line 156: for (const auto &value: rhs) { please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/7192431f_96d9cd27 PS18, Line 156: for (const auto &value: rhs) { suspect code indent for conditional statements (8, 12)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/1d78795e_c7905d93 PS18, Line 156: for (const auto &value: rhs) { need consistent spacing around '&' (ctx:WxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/2b6d91f5_bbc7af20 PS18, Line 156: for (const auto &value: rhs) { spaces required around that ':' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/36d5ccab_30ffdaf3 PS18, Line 156: for (const auto &value: rhs) { braces {} are not necessary for single statement blocks
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/23a61533_4ae370d9 PS18, Line 157: node.push_back(value); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/5a2861b3_635234e5 PS18, Line 157: node.push_back(value); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/c2040dc7_053813ab PS18, Line 158: } code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/2362fd06_5b07a549 PS18, Line 158: } please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/c536685f_24eb01ba PS18, Line 159: return node; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/dab6c21b_266f94a5 PS18, Line 159: return node; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/3f7533b9_efda5e1e PS18, Line 160: } please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/46752210_7b172a43 PS18, Line 162: static bool decode(const Node& node, QStringList& rhs) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/e32e8b99_eb679721 PS18, Line 162: static bool decode(const Node& node, QStringList& rhs) need consistent spacing around '&' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/ad5b1415_fcb3e656 PS18, Line 162: static bool decode(const Node& node, QStringList& rhs) need consistent spacing around '&' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/11cbbc78_82c45255 PS18, Line 162: static bool decode(const Node& node, QStringList& rhs) open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/0461882f_27487c62 PS18, Line 163: { please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/c7f1638a_9c9334c9 PS18, Line 164: if (!node.IsSequence()) code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/8d0ac77b_c9ebfb42 PS18, Line 164: if (!node.IsSequence()) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/1f79805a_a81144f1 PS18, Line 164: if (!node.IsSequence()) suspect code indent for conditional statements (8, 12)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/c62f1d6b_480580cb PS18, Line 165: return false; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/4e5de43a_9c741d41 PS18, Line 165: return false; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/51595ed3_f09bd642 PS18, Line 167: rhs.clear(); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/054e7fa7_d6506cde PS18, Line 167: rhs.clear(); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/881d04b4_2cdf9513 PS18, Line 168: const_iterator it = node.begin(); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/185f3143_755fec5d PS18, Line 168: const_iterator it = node.begin(); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/1424bcfc_d4e4d567 PS18, Line 169: while (it != node.end()) code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/d5053b6a_8f4a5016 PS18, Line 169: while (it != node.end()) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/357f0bed_4871d061 PS18, Line 169: while (it != node.end()) that open brace { should be on the previous line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/368cbacb_7109183c PS18, Line 169: while (it != node.end()) suspect code indent for conditional statements (8, 12)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/e8b5b405_6e4e0855 PS18, Line 170: { code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/1bcbfeaa_8cb700eb PS18, Line 170: { please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/e2ac9d61_6bfa9d50 PS18, Line 171: rhs.push_back(it->as<QString>()); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/f24de8a3_358ff5ae PS18, Line 171: rhs.push_back(it->as<QString>()); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/40beac4d_e49971f9 PS18, Line 171: rhs.push_back(it->as<QString>()); spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/9229cd13_731fc0cf PS18, Line 171: rhs.push_back(it->as<QString>()); spaces required around that '>' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/a1fe7c9c_c867cf6e PS18, Line 172: ++it; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/575d1940_d6b00fca PS18, Line 172: ++it; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/eda695e3_9adcc0f7 PS18, Line 173: } code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/c8ae5a25_c8a70974 PS18, Line 173: } please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/0c3167ea_b0b3b866 PS18, Line 174: return true; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/b293ac1b_46075156 PS18, Line 174: return true; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132344): https://review.coreboot.org/c/coreboot/+/58854/comment/127eced6_076c833c PS18, Line 175: } please, no spaces at the start of a line
-
build bot (Jenkins) (Code Review)