Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35148 )
Change subject: soc/intel/common/timer: Make TSC frequency calculation dynamically
......................................................................
Patch Set 11:
(2 comments)
https://review.coreboot.org/c/coreboot/+/35148/9//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/35148/9//COMMIT_MSG@16
PS9, Line 16: On SKL/KBL/CML CPUID.15h.ecx = nominal core crystal clock = 0 Hz
Thanks. I didn't get the relation between the two paragraphs and it's much clearer to me now. […]
yes Patrick, correct
https://review.coreboot.org/c/coreboot/+/35148/10/src/soc/intel/common/block...
File src/soc/intel/common/block/timer/timer.c:
https://review.coreboot.org/c/coreboot/+/35148/10/src/soc/intel/common/block...
PS10, Line 124: calculate
We don't calculate anything in that function, but (according to comments) only return the bus freque […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35148
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If660a4b8d12e54b39252bce62bcc0ffcc967f5da
Gerrit-Change-Number: 35148
Gerrit-PatchSet: 11
Gerrit-Owner: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Lean Sheng Tan
lean.sheng.tan@intel.com
Gerrit-Reviewer: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Reviewer: Meera Ravindranath
meera.ravindranath@intel.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: V Sowmya
v.sowmya@intel.com
Gerrit-Reviewer: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-CC: Patrick Georgi
pgeorgi@google.com
Gerrit-Comment-Date: Mon, 02 Sep 2019 14:13:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik
subrata.banik@intel.com
Comment-In-Reply-To: Patrick Georgi
pgeorgi@google.com
Gerrit-MessageType: comment