Attention is currently required from: Tim Wawrzynczak, Paul Menzel, Sridhar Siricilla, Kane Chen.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63293 )
Change subject: soc/intel/alderlake: Allow mainboard to configure USB2 Phy power gating
......................................................................
Patch Set 5: Code-Review+1
(1 comment)
File src/soc/intel/alderlake/chip.h:
https://review.coreboot.org/c/coreboot/+/63293/comment/4b672730_a12f5564
PS4, Line 572: Default 0. Set this to 1 in order to disable PCH USB2 Phy Power gating.
I will add the comment in other CL.
I'd prefer if you could mention doc#723158 here as well.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/63293
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3d80a3e36c6f8a3c0f174f955b11457752809f4d
Gerrit-Change-Number: 63293
Gerrit-PatchSet: 5
Gerrit-Owner: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Kane Chen
kane.chen@intel.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Attention: Kane Chen
kane.chen@intel.com
Gerrit-Comment-Date: Fri, 08 Apr 2022 08:10:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Sridhar Siricilla
sridhar.siricilla@intel.com
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment