Change in coreboot[master]: util/mb/google/hatch: script can take optional bug parameter

[Paul Fagerburg (Code Review)]

Paul Fagerburg has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/35606 )

Change subject: util/mb/google/hatch: script can take optional bug parameter
......................................................................

util/mb/google/hatch: script can take optional bug parameter

When creating a new variant, adding a bug parameter after the name
of the variant will populate the BUG= field in the commit message.
If the paramter is not present, then BUG=None.

Signed-off-by: Paul Fagerburg 
Change-Id: I3e08df5d80a5684c9f3675e3c0a8346240171cd3
---
M util/mainboard/google/hatch/create_coreboot_variant.sh
1 file changed, 7 insertions(+), 4 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/06/35606/1

diff --git a/util/mainboard/google/hatch/create_coreboot_variant.sh b/util/mainboard/google/hatch/create_coreboot_variant.sh
index c6cbb49..065fb6d 100755
--- a/util/mainboard/google/hatch/create_coreboot_variant.sh
+++ b/util/mainboard/google/hatch/create_coreboot_variant.sh
@@ -13,9 +13,9 @@
 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 # GNU General Public License for more details.

-if [[ "$#" -ne 1 ]]; then
-  echo "Usage: $0 variant_name"
-  echo "e.g. $0 kohaku"
+if [[ "$#" -lt 1 ]]; then
+  echo "Usage: $0 variant_name [bug_number]"
+  echo "e.g. $0 kohaku b:140261109"
   echo "Adds a new variant of Hatch to Kconfig and Kconfig.name, creates the"
   echo "skeleton files for acpi, ec, and gpio, copies the makefile for"
   echo "SPD sources, and sets up a basic overridetree"
@@ -32,6 +32,9 @@
 VARIANT="${1,,}"
 VARIANT_UPPER="${VARIANT^^}"

+# Assign BUG= text, or "None" if that parameter wasn't specified.
+BUG=${2:-None}
+
 # This script and the templates live in util/mainboard/google/hatch
 # We need to create files in src/mainboard/google/hatch
 pushd "${BASH_SOURCE%/*}" || exit 1
@@ -69,7 +72,7 @@
 # Now commit the files.
 git commit -sm "${BASE}: Create ${VARIANT} variant

-BUG=none
+BUG=${BUG}
 TEST=util/abuild/abuild -p none -t google/${BASE} -x -a
 make sure the build includes GOOGLE_${VARIANT_UPPER}"

[Patrick Georgi (Code Review)]

Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35606 )

Change subject: util/mb/google/hatch: script can take optional bug parameter
......................................................................

Patch Set 1: Code-Review+2

[Andrew McRae (Code Review)]

Andrew McRae has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35606 )

Change subject: util/mb/google/hatch: script can take optional bug parameter
......................................................................

Patch Set 1:

(3 comments)

https://review.coreboot.org/c/coreboot/+/35606/1//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/35606/1//COMMIT_MSG@11 
PS1, Line 11: paramter
parameter

https://review.coreboot.org/c/coreboot/+/35606/1/util/mainboard/google/hatch... 
File util/mainboard/google/hatch/create_coreboot_variant.sh:

https://review.coreboot.org/c/coreboot/+/35606/1/util/mainboard/google/hatch... 
PS1, Line 17: bug_number
bug_number -> b:bug_number

https://review.coreboot.org/c/coreboot/+/35606/1/util/mainboard/google/hatch... 
PS1, Line 35: text
BUG= text -> BUG=text

[Paul Fagerburg (Code Review)]

Hello Andrew McRae, Edward O'Callaghan, Tim Wawrzynczak, Shelley Chen, build bot (Jenkins), Patrick Georgi, Furquan Shaikh,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/35606

to look at the new patch set (#3).

Change subject: util/mb/google/hatch: script can take optional bug parameter
......................................................................

util/mb/google/hatch: script can take optional bug parameter

When creating a new variant, adding a bug parameter after the name
of the variant will populate the BUG= field in the commit message.
If the paramter is not present, then BUG=None.

Signed-off-by: Paul Fagerburg 
Change-Id: I3e08df5d80a5684c9f3675e3c0a8346240171cd3
---
M util/mainboard/google/hatch/create_coreboot_variant.sh
1 file changed, 8 insertions(+), 4 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/06/35606/3

[Paul Fagerburg (Code Review)]

Hello Andrew McRae, Edward O'Callaghan, Tim Wawrzynczak, Shelley Chen, build bot (Jenkins), Patrick Georgi, Furquan Shaikh,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/35606

to look at the new patch set (#4).

Change subject: util/mb/google/hatch: script can take optional bug parameter
......................................................................

util/mb/google/hatch: script can take optional bug parameter

When creating a new variant, adding a bug parameter after the name
of the variant will populate the BUG= field in the commit message.
If the parameter is not present, then BUG=None.

Signed-off-by: Paul Fagerburg 
Change-Id: I3e08df5d80a5684c9f3675e3c0a8346240171cd3
---
M util/mainboard/google/hatch/create_coreboot_variant.sh
1 file changed, 8 insertions(+), 4 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/06/35606/4

[Paul Fagerburg (Code Review)]

Paul Fagerburg has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35606 )

Change subject: util/mb/google/hatch: script can take optional bug parameter
......................................................................

Patch Set 4:

(3 comments)

https://review.coreboot.org/c/coreboot/+/35606/1//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/35606/1//COMMIT_MSG@11 
PS1, Line 11: paramter
> parameter

Done

https://review.coreboot.org/c/coreboot/+/35606/1/util/mainboard/google/hatch... 
File util/mainboard/google/hatch/create_coreboot_variant.sh:

https://review.coreboot.org/c/coreboot/+/35606/1/util/mainboard/google/hatch... 
PS1, Line 17: bug_number
> bug_number -> b:bug_number

Done

https://review.coreboot.org/c/coreboot/+/35606/1/util/mainboard/google/hatch... 
PS1, Line 35: text
> BUG= text -> BUG=text

Clarified by rewording. "BUG=" was meant to function like an adjective, just like you might write "Assign replacement text, or 'None' if ..."

[Paul Fagerburg (Code Review)]

Hello Andrew McRae, Edward O'Callaghan, Tim Wawrzynczak, Shelley Chen, build bot (Jenkins), Patrick Georgi, Furquan Shaikh,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/35606

to look at the new patch set (#9).

Change subject: util/mb/google/hatch: script can take optional bug parameter
......................................................................

util/mb/google/hatch: script can take optional bug parameter

When creating a new variant, adding a bug parameter after the name
of the variant will populate the BUG= field in the commit message.
If the parameter is not present, then BUG=None.

Signed-off-by: Paul Fagerburg 
Change-Id: I3e08df5d80a5684c9f3675e3c0a8346240171cd3
---
M util/mainboard/google/hatch/create_coreboot_variant.sh
1 file changed, 8 insertions(+), 4 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/06/35606/9

[Andrew McRae (Code Review)]

Andrew McRae has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35606 )

Change subject: util/mb/google/hatch: script can take optional bug parameter
......................................................................

Patch Set 9: Code-Review+1

[Edward O'Callaghan (Code Review)]

Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35606 )

Change subject: util/mb/google/hatch: script can take optional bug parameter
......................................................................

Patch Set 9: Code-Review+2

[Patrick Georgi (Code Review)]

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/35606 )

Change subject: util/mb/google/hatch: script can take optional bug parameter
......................................................................

util/mb/google/hatch: script can take optional bug parameter

When creating a new variant, adding a bug parameter after the name
of the variant will populate the BUG= field in the commit message.
If the parameter is not present, then BUG=None.

Signed-off-by: Paul Fagerburg 
Change-Id: I3e08df5d80a5684c9f3675e3c0a8346240171cd3
Reviewed-on: https://review.coreboot.org/c/coreboot/+/35606
Tested-by: build bot (Jenkins) 
Reviewed-by: Andrew McRae 
Reviewed-by: Edward O'Callaghan 
---
M util/mainboard/google/hatch/create_coreboot_variant.sh
1 file changed, 8 insertions(+), 4 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Edward O'Callaghan: Looks good to me, approved
  Andrew McRae: Looks good to me, but someone else must approve

diff --git a/util/mainboard/google/hatch/create_coreboot_variant.sh b/util/mainboard/google/hatch/create_coreboot_variant.sh
index 739c2f1..569143f 100755
--- a/util/mainboard/google/hatch/create_coreboot_variant.sh
+++ b/util/mainboard/google/hatch/create_coreboot_variant.sh
@@ -15,9 +15,9 @@

export LC_ALL=C

-if [[ "$#" -ne 1 ]]; then
-  echo "Usage: $0 variant_name"
-  echo "e.g. $0 kohaku"
+if [[ "$#" -lt 1 ]]; then
+  echo "Usage: $0 variant_name [b:bug_number]"
+  echo "e.g. $0 kohaku b:140261109"
   echo "Adds a new variant of Hatch to Kconfig and Kconfig.name, creates the"
   echo "skeleton files for acpi, ec, and gpio, copies the makefile for"
   echo "SPD sources, and sets up a basic overridetree"
@@ -34,6 +34,10 @@
 VARIANT="${1,,}"
 VARIANT_UPPER="${VARIANT^^}"

+# Assign text for the "BUG=" part of the commit, or use "None" if that
+# parameter wasn't specified.
+BUG=${2:-None}
+
 # This script and the templates live in util/mainboard/google/hatch
 # We need to create files in src/mainboard/google/hatch
 pushd "${BASH_SOURCE%/*}" || exit 1
@@ -71,7 +75,7 @@
 # Now commit the files.
 git commit -sm "${BASE}: Create ${VARIANT} variant

-BUG=none
+BUG=${BUG}
 TEST=util/abuild/abuild -p none -t google/${BASE} -x -a
 make sure the build includes GOOGLE_${VARIANT_UPPER}"