Attention is currently required from: Martin L Roth, Matt DeVillier, Stefan Reinauer.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74869 )
Change subject: payloads/edk2: Add Kconfig to enable UEFI SecureBoot support ......................................................................
Patch Set 2: Code-Review+1
(5 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/74869/comment/1cbc28e2_3180d9e7 PS2, Line 7: SecureBoot It’s spelled with a space: Secure Boot [1]. (Also several times below.)
[1]: https://en.wikipedia.org/wiki/UEFI#Secure_Boot.
https://review.coreboot.org/c/coreboot/+/74869/comment/70ded609_77bf2147 PS2, Line 14: payload, SecureBoot status reported properly by Linux/Windows. Does it work in QEMU and should such a run test be added to the build system somehow? Do you have documentation, what keys are used?
Patchset:
PS2: Nice work!
File payloads/external/edk2/Kconfig:
https://review.coreboot.org/c/coreboot/+/74869/comment/8f08f9e2_0038be49 PS2, Line 250: SecureBoot Secure Boot
https://review.coreboot.org/c/coreboot/+/74869/comment/033a2c95_1a9260f7 PS2, Line 251: SecureBoot Ditto.