Attention is currently required from: Cliff Huang, Intel coreboot Reviewers, Jayvik Desai, Jérémy Compostella, Kapil Porwal, Pranava Y N.
Subrata Banik has posted comments on this change by Cliff Huang. ( https://review.coreboot.org/c/coreboot/+/86290?usp=email )
Change subject: soc/intel/pantherlake: Enable multiple ACPI devices for GPIO
......................................................................
Patch Set 7:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/86290/comment/1cceffdd_8cfa95db?usp... :
PS7, Line 53:
@Subrata, Yes. this issue is found while we are enabling touchscreen and touchpad wake, where the wake is specified using GpioInt in the _CRS method. The specified ACPI GPIO number in GpioInt is used to map to the PAD in corresponding pinctrl instance. Note that for those _CRS methods that use Interrupt descriptor, such as touchscreen/touchpad in LPSS-i2c mode, are not impacted as the interrupt number is used directly and does not need to find out from any of the pinctrl instances.
thanks, in that case. can you please add a TEST line saying verified S0ix using touchscreen/touchpad attached
--
To view, visit
https://review.coreboot.org/c/coreboot/+/86290?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ic2ba67518fa173e13975478ccae5f8a1772ebf08
Gerrit-Change-Number: 86290
Gerrit-PatchSet: 7
Gerrit-Owner: Cliff Huang
cliff.huang@intel.com
Gerrit-Reviewer: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Reviewer: Intel coreboot Reviewers
intel_coreboot_reviewers@intel.com
Gerrit-Reviewer: Jayvik Desai
jayvik@google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Pranava Y N
pranavayn@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Jayvik Desai
jayvik@google.com
Gerrit-Attention: Cliff Huang
cliff.huang@intel.com
Gerrit-Attention: Intel coreboot Reviewers
intel_coreboot_reviewers@intel.com
Gerrit-Attention: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Pranava Y N
pranavayn@google.com
Gerrit-Comment-Date: Fri, 14 Feb 2025 06:56:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Cliff Huang
cliff.huang@intel.com
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com