Attention is currently required from: Jakub Czapiga, Paul Fagerburg, Jan Dabros.
Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56305 )
Change subject: tests: Add lib/lzmadecode-test test case
......................................................................
Patch Set 1:
(1 comment)
File tests/lib/lzmadecode-test.c:
https://review.coreboot.org/c/coreboot/+/56305/comment/5c1928f2_87de23b5
PS1, Line 97: LzmaDecode(&dstate, test_state->encoded_data_ptr + data_offset,
I assumed that ulzman() function is just a wrapper, but if it is the only way the coreboot uses the […]
Everything in lzmadecode.c is the third-party code directly copied into the coreboot repo. I don't think it needs to be tested individually. lzma.c is the coreboot wrapper that everything else in coreboot uses and that's the (only) entry point into that functionality we care about.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/56305
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3733adc32ee2f5583f6d2b56df379f1bd170c233
Gerrit-Change-Number: 56305
Gerrit-PatchSet: 1
Gerrit-Owner: Jakub Czapiga
jacz@semihalf.com
Gerrit-Reviewer: Jan Dabros
jsd@semihalf.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Paul Fagerburg
pfagerburg@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Jakub Czapiga
jacz@semihalf.com
Gerrit-Attention: Paul Fagerburg
pfagerburg@chromium.org
Gerrit-Attention: Jan Dabros
jsd@semihalf.com
Gerrit-Comment-Date: Tue, 27 Jul 2021 22:17:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Jakub Czapiga
jacz@semihalf.com
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Gerrit-MessageType: comment