Hello Daniel Kurtz,
I'd like you to do a code review. Please visit
https://review.coreboot.org/c/coreboot/+/39588
to review the following change.
Change subject: drivers/i2c/designware: Add 150MHz clock speed ......................................................................
drivers/i2c/designware: Add 150MHz clock speed
BUG=b:143885765 TEST=I2c clock speed on trembyle is 400kHz
Change-Id: I50e904822823a6fc173d4d4b76f0882b4ce81ae8 Signed-off-by: Martin Roth martinroth@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/coreboot/+... Reviewed-by: Daniel Kurtz djkurtz@chromium.org --- M src/drivers/i2c/designware/dw_i2c.c 1 file changed, 7 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/88/39588/1
diff --git a/src/drivers/i2c/designware/dw_i2c.c b/src/drivers/i2c/designware/dw_i2c.c index 9eda827..5e57e5a 100644 --- a/src/drivers/i2c/designware/dw_i2c.c +++ b/src/drivers/i2c/designware/dw_i2c.c @@ -214,6 +214,13 @@ }, }, { + .clk_speed_mhz = 150, + .freq = { + .ticks = 600, + .ns = 4000, + }, + }, + { .clk_speed_mhz = 216, .freq = { .ticks = 1080,
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39588 )
Change subject: drivers/i2c/designware: Add 150MHz clock speed ......................................................................
Patch Set 1: Code-Review+2
(2 comments)
https://review.coreboot.org/c/coreboot/+/39588/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/39588/1//COMMIT_MSG@10 PS1, Line 10: I2c I2C ?
https://review.coreboot.org/c/coreboot/+/39588/1//COMMIT_MSG@14 PS1, Line 14: https://chromium-review.googlesource.com/c/chromiumos/third_party/coreboot/+... You can shorten this by only using the CL number:
https://chromium-review.googlesource.com/1970655
Hello Daniel Kurtz, build bot (Jenkins), Angel Pons,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/39588
to look at the new patch set (#2).
Change subject: drivers/i2c/designware: Add 150MHz clock speed ......................................................................
drivers/i2c/designware: Add 150MHz clock speed
BUG=b:143885765 TEST=I2C clock speed on trembyle is 400kHz
Change-Id: I50e904822823a6fc173d4d4b76f0882b4ce81ae8 Signed-off-by: Martin Roth martinroth@chromium.org Reviewed-on: https://chromium-review.googlesource.com/1970655 Reviewed-by: Daniel Kurtz djkurtz@chromium.org --- M src/drivers/i2c/designware/dw_i2c.c 1 file changed, 7 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/88/39588/2
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39588 )
Change subject: drivers/i2c/designware: Add 150MHz clock speed ......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/coreboot/+/39588/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/39588/1//COMMIT_MSG@10 PS1, Line 10: I2c
I2C ?
Done
https://review.coreboot.org/c/coreboot/+/39588/1//COMMIT_MSG@14 PS1, Line 14: https://chromium-review.googlesource.com/c/chromiumos/third_party/coreboot/+...
You can shorten this by only using the CL number: […]
Done
Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/39588 )
Change subject: drivers/i2c/designware: Add 150MHz clock speed ......................................................................
drivers/i2c/designware: Add 150MHz clock speed
BUG=b:143885765 TEST=I2C clock speed on trembyle is 400kHz
Change-Id: I50e904822823a6fc173d4d4b76f0882b4ce81ae8 Signed-off-by: Martin Roth martinroth@chromium.org Reviewed-on: https://chromium-review.googlesource.com/1970655 Reviewed-by: Daniel Kurtz djkurtz@chromium.org Reviewed-on: https://review.coreboot.org/c/coreboot/+/39588 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Angel Pons th3fanbus@gmail.com --- M src/drivers/i2c/designware/dw_i2c.c 1 file changed, 7 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved
diff --git a/src/drivers/i2c/designware/dw_i2c.c b/src/drivers/i2c/designware/dw_i2c.c index 9eda827..5e57e5a 100644 --- a/src/drivers/i2c/designware/dw_i2c.c +++ b/src/drivers/i2c/designware/dw_i2c.c @@ -214,6 +214,13 @@ }, }, { + .clk_speed_mhz = 150, + .freq = { + .ticks = 600, + .ns = 4000, + }, + }, + { .clk_speed_mhz = 216, .freq = { .ticks = 1080,
-
Angel Pons (Code Review) -
Felix Held (Code Review)