Change in coreboot[master]: mb/google/dedede: Enable ELAN touch screen for Waddledoo

[Dtrain Hsu (Code Review)]

Dtrain Hsu has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/40251 )

Change subject: mb/google/dedede: Enable ELAN touch screen for Waddledoo
......................................................................

mb/google/dedede: Enable ELAN touch screen for Waddledoo

Add ELAN EKTH6918 USI touchsreen support.

BUG=b:152936745
TEST="emerge-dedede coreboot chromeos-bootimage", build successful.

Signed-off-by: Dtrain Hsu 
Change-Id: I030c7d7e76a9705be06fe907c4ac279e247cb163
---
M src/mainboard/google/dedede/variants/waddledoo/overridetree.cb
1 file changed, 19 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/51/40251/1

diff --git a/src/mainboard/google/dedede/variants/waddledoo/overridetree.cb b/src/mainboard/google/dedede/variants/waddledoo/overridetree.cb
index 3f138e4..ae4f580 100644
--- a/src/mainboard/google/dedede/variants/waddledoo/overridetree.cb
+++ b/src/mainboard/google/dedede/variants/waddledoo/overridetree.cb
@@ -75,6 +75,25 @@
    			register "hid_desc_reg_offset" = "0x00"
    			device i2c 5c on end
    		end
+			chip drivers/i2c/hid
+				register "generic.hid" = ""ELAN9050""
+				register "generic.desc" = ""ELAN Touchscreen""
+				register "generic.irq" = "ACPI_IRQ_EDGE_LOW(GPP_D4_IRQ)"
+				register "generic.probed" = "1"
+				register "generic.reset_gpio" =
+							"ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_D5)"
+				register "generic.reset_delay_ms" = "20"
+				register "generic.reset_off_delay_ms" = "2"
+				register "generic.stop_gpio" =
+							"ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_A11)"
+				register "generic.stop_delay_ms" = "280"
+				register "generic.enable_gpio" =
+							"ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_D6)"
+				register "generic.enable_delay_ms" = "10"
+				register "generic.has_power_resource" = "1"
+				register "hid_desc_reg_offset" = "0x01"
+				device i2c 15 on end
+			end
    	end # I2C 2
    	device pci 1c.7 on
    		chip drivers/intel/wifi

[Marco Chen (Code Review)]

Marco Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40251 )

Change subject: mb/google/dedede: Enable ELAN touch screen for Waddledoo
......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/c/coreboot/+/40251/1/src/mainboard/google/dedede... 
File src/mainboard/google/dedede/variants/waddledoo/overridetree.cb:

https://review.coreboot.org/c/coreboot/+/40251/1/src/mainboard/google/dedede... 
PS1, Line 89: 				register "generic.stop_delay_ms" = "280"
we also need stop_off_delay_ms to 2 as well

[Dtrain Hsu (Code Review)]

Hello build bot (Jenkins), Furquan Shaikh, Marco Chen, EricR Lai,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/40251

to look at the new patch set (#2).

Change subject: mb/google/dedede: Enable ELAN touch screen for Waddledoo
......................................................................

mb/google/dedede: Enable ELAN touch screen for Waddledoo

Add ELAN EKTH6918 USI touchsreen support.

BUG=b:152936745
TEST="emerge-dedede coreboot chromeos-bootimage", build successful.

Signed-off-by: Dtrain Hsu 
Change-Id: I030c7d7e76a9705be06fe907c4ac279e247cb163
---
M src/mainboard/google/dedede/variants/waddledoo/overridetree.cb
1 file changed, 20 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/51/40251/2

[Dtrain Hsu (Code Review)]

Dtrain Hsu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40251 )

Change subject: mb/google/dedede: Enable ELAN touch screen for Waddledoo
......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/40251/1/src/mainboard/google/dedede... 
File src/mainboard/google/dedede/variants/waddledoo/overridetree.cb:

https://review.coreboot.org/c/coreboot/+/40251/1/src/mainboard/google/dedede... 
PS1, Line 89: 				register "generic.stop_delay_ms" = "280"
> we also need stop_off_delay_ms to 2 as well

Done

[EricR Lai (Code Review)]

EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40251 )

Change subject: mb/google/dedede: Enable ELAN touch screen for Waddledoo
......................................................................

Patch Set 2: Code-Review+2

[Paul Menzel (Code Review)]

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40251 )

Change subject: mb/google/dedede: Enable ELAN touch screen for Waddledoo
......................................................................

Patch Set 3:

(1 comment)

https://review.coreboot.org/c/coreboot/+/40251/3//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/40251/3//COMMIT_MSG@9 
PS3, Line 9: touchsreen
touchscreen

[Dtrain Hsu (Code Review)]

Hello build bot (Jenkins), Furquan Shaikh, Marco Chen, EricR Lai,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/40251

to look at the new patch set (#4).

Change subject: mb/google/dedede: Enable ELAN touch screen for Waddledoo
......................................................................

mb/google/dedede: Enable ELAN touch screen for Waddledoo

Add ELAN EKTH6918 USI touchscreen support.

BUG=b:152936745
TEST="emerge-dedede coreboot chromeos-bootimage", build successful.

Signed-off-by: Dtrain Hsu 
Change-Id: I030c7d7e76a9705be06fe907c4ac279e247cb163
---
M src/mainboard/google/dedede/variants/waddledoo/overridetree.cb
1 file changed, 20 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/51/40251/4

[Dtrain Hsu (Code Review)]

Dtrain Hsu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40251 )

Change subject: mb/google/dedede: Enable ELAN touch screen for Waddledoo
......................................................................

Patch Set 5:

(1 comment)

https://review.coreboot.org/c/coreboot/+/40251/3//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/40251/3//COMMIT_MSG@9 
PS3, Line 9: touchsreen
> touchscreen

Done

[Marco Chen (Code Review)]

Marco Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40251 )

Change subject: mb/google/dedede: Enable ELAN touch screen for Waddledoo
......................................................................

Patch Set 5: Code-Review+2

[Karthik Ramasubramanian (Code Review)]

Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40251 )

Change subject: mb/google/dedede: Enable ELAN touch screen for Waddledoo
......................................................................

Patch Set 6:

(2 comments)

https://review.coreboot.org/c/coreboot/+/40251/6/src/mainboard/google/dedede... 
File src/mainboard/google/dedede/variants/waddledoo/overridetree.cb:

https://review.coreboot.org/c/coreboot/+/40251/6/src/mainboard/google/dedede... 
PS6, Line 87: "280"
I think the values in stop_delay_ms and stop_off_delay_ms needs to be swapped.

As per the description for these parameters:
stop_delay_ms - Delay to be inserted after disabling stop.
stop_off_delay_ms - Delay to be inserted after enabling stop.

As per the datasheet, after enabling stop/report line all the I2C commands/transactions should start only after 280 ms. Also after disabling stop/report, host should wait 2 ms before toggling any other signal.

https://review.coreboot.org/c/coreboot/+/40251/6/src/mainboard/google/dedede... 
PS6, Line 91: 10
Why is 10 ms required? If I am reading the datasheet correctly 1 ms is good, unless I am looking at the wrong line.

[Marco Chen (Code Review)]

Marco Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40251 )

Change subject: mb/google/dedede: Enable ELAN touch screen for Waddledoo
......................................................................

Patch Set 6:

(1 comment)

https://review.coreboot.org/c/coreboot/+/40251/6/src/mainboard/google/dedede... 
File src/mainboard/google/dedede/variants/waddledoo/overridetree.cb:

https://review.coreboot.org/c/coreboot/+/40251/6/src/mainboard/google/dedede... 
PS6, Line 87: "280"
> I think the values in stop_delay_ms and stop_off_delay_ms needs to be swapped. […]

Referring to [1], the stop_delay_ms is in _ON power sequence so 280ms here would be correct?

[1] https://chromium.googlesource.com/chromiumos/third_party/coreboot/+/refs/hea...

[Dtrain Hsu (Code Review)]

Dtrain Hsu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40251 )

Change subject: mb/google/dedede: Enable ELAN touch screen for Waddledoo
......................................................................

Patch Set 6:

(1 comment)

https://review.coreboot.org/c/coreboot/+/40251/6/src/mainboard/google/dedede... 
File src/mainboard/google/dedede/variants/waddledoo/overridetree.cb:

https://review.coreboot.org/c/coreboot/+/40251/6/src/mainboard/google/dedede... 
PS6, Line 87: "280"
> Referring to [1], the stop_delay_ms is in _ON power sequence so 280ms here would be correct? […]

_ON:  stop_delay_ms = After stop pin high, then delay (stop_delay_ms).
_OFF: stop_off_delay_ms = stop pin low -> reset low
I think it is correct.

[Dtrain Hsu (Code Review)]

Hello build bot (Jenkins), Furquan Shaikh, Marco Chen, Karthik Ramasubramanian, EricR Lai,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/40251

to look at the new patch set (#7).

Change subject: mb/google/dedede: Enable ELAN touch screen for Waddledoo
......................................................................

mb/google/dedede: Enable ELAN touch screen for Waddledoo

Add ELAN EKTH6918 USI touchscreen support.

BUG=b:152936745
TEST="emerge-dedede coreboot chromeos-bootimage", build successful.

Signed-off-by: Dtrain Hsu 
Change-Id: I030c7d7e76a9705be06fe907c4ac279e247cb163
---
M src/mainboard/google/dedede/variants/waddledoo/overridetree.cb
1 file changed, 20 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/51/40251/7

[Dtrain Hsu (Code Review)]

Dtrain Hsu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40251 )

Change subject: mb/google/dedede: Enable ELAN touch screen for Waddledoo
......................................................................

Patch Set 7:

(1 comment)

https://review.coreboot.org/c/coreboot/+/40251/6/src/mainboard/google/dedede... 
File src/mainboard/google/dedede/variants/waddledoo/overridetree.cb:

https://review.coreboot.org/c/coreboot/+/40251/6/src/mainboard/google/dedede... 
PS6, Line 91: 10
> Why is 10 ms required? If I am reading the datasheet correctly 1 ms is good, unless I am looking at  […]

Thanks Karthik. Correct it.

[Marco Chen (Code Review)]

Marco Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40251 )

Change subject: mb/google/dedede: Enable ELAN touch screen for Waddledoo
......................................................................

Patch Set 7: Code-Review+2

[Karthik Ramasubramanian (Code Review)]

Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40251 )

Change subject: mb/google/dedede: Enable ELAN touch screen for Waddledoo
......................................................................

Patch Set 7: Code-Review+2

(2 comments)

https://review.coreboot.org/c/coreboot/+/40251/6/src/mainboard/google/dedede... 
File src/mainboard/google/dedede/variants/waddledoo/overridetree.cb:

https://review.coreboot.org/c/coreboot/+/40251/6/src/mainboard/google/dedede... 
PS6, Line 87: "280"
> _ON:  stop_delay_ms = After stop pin high, then delay (stop_delay_ms). […]

I misunderstood. Thanks for correcting me.

https://review.coreboot.org/c/coreboot/+/40251/6/src/mainboard/google/dedede... 
PS6, Line 91: 10
> Thanks Karthik. Correct it.

Done

[EricR Lai (Code Review)]

EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40251 )

Change subject: mb/google/dedede: Enable ELAN touch screen for Waddledoo
......................................................................

Patch Set 7: Code-Review+2

[Karthik Ramasubramanian (Code Review)]

Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40251 )

Change subject: mb/google/dedede: Enable ELAN touch screen for Waddledoo
......................................................................

Patch Set 7:

(1 comment)

https://review.coreboot.org/c/coreboot/+/40251/7//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/40251/7//COMMIT_MSG@7 
PS7, Line 7:  
Nit: touchscreen (No space between touch screen).

Change in coreboot[master]: mb/google/dedede: Enable ELAN touchscreen for Waddledoo

[Dtrain Hsu (Code Review)]

Hello build bot (Jenkins), Furquan Shaikh, Marco Chen, Karthik Ramasubramanian, EricR Lai,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/40251

to look at the new patch set (#8).

Change subject: mb/google/dedede: Enable ELAN touchscreen for Waddledoo
......................................................................

mb/google/dedede: Enable ELAN touchscreen for Waddledoo

Add ELAN EKTH6918 USI touchscreen support.

BUG=b:152936745
TEST="emerge-dedede coreboot chromeos-bootimage", build successful.

Signed-off-by: Dtrain Hsu 
Change-Id: I030c7d7e76a9705be06fe907c4ac279e247cb163
---
M src/mainboard/google/dedede/variants/waddledoo/overridetree.cb
1 file changed, 20 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/51/40251/8

Change in coreboot[master]: mb/google/dedede: Enable ELAN touchscreen for Waddledoo

[Karthik Ramasubramanian (Code Review)]

Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40251 )

Change subject: mb/google/dedede: Enable ELAN touchscreen for Waddledoo
......................................................................

Patch Set 8:

(1 comment)

https://review.coreboot.org/c/coreboot/+/40251/7//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/40251/7//COMMIT_MSG@7 
PS7, Line 7:
> Nit: touchscreen (No space between touch screen).

Done

Change in coreboot[master]: mb/google/dedede: Enable ELAN touchscreen for Waddledoo

[Dtrain Hsu (Code Review)]

Dtrain Hsu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40251 )

Change subject: mb/google/dedede: Enable ELAN touchscreen for Waddledoo
......................................................................

Patch Set 9:

(1 comment)

https://review.coreboot.org/c/coreboot/+/40251/7//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/40251/7//COMMIT_MSG@7 
PS7, Line 7:
> Nit: touchscreen (No space between touch screen).

Done

Change in coreboot[master]: mb/google/dedede: Enable ELAN touchscreen for Waddledoo

[Patrick Georgi (Code Review)]

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/40251 )

Change subject: mb/google/dedede: Enable ELAN touchscreen for Waddledoo
......................................................................

mb/google/dedede: Enable ELAN touchscreen for Waddledoo

Add ELAN EKTH6918 USI touchscreen support.

BUG=b:152936745
TEST="emerge-dedede coreboot chromeos-bootimage", build successful.

Signed-off-by: Dtrain Hsu 
Change-Id: I030c7d7e76a9705be06fe907c4ac279e247cb163
Reviewed-on: https://review.coreboot.org/c/coreboot/+/40251
Tested-by: build bot (Jenkins) 
Reviewed-by: Marco Chen 
Reviewed-by: Karthik Ramasubramanian 
Reviewed-by: EricR Lai 
---
M src/mainboard/google/dedede/variants/waddledoo/overridetree.cb
1 file changed, 20 insertions(+), 0 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Marco Chen: Looks good to me, approved
  Karthik Ramasubramanian: Looks good to me, approved
  EricR Lai: Looks good to me, approved

diff --git a/src/mainboard/google/dedede/variants/waddledoo/overridetree.cb b/src/mainboard/google/dedede/variants/waddledoo/overridetree.cb
index cc9e651..920c179 100644
--- a/src/mainboard/google/dedede/variants/waddledoo/overridetree.cb
+++ b/src/mainboard/google/dedede/variants/waddledoo/overridetree.cb
@@ -73,6 +73,26 @@
    			register "hid_desc_reg_offset" = "0x00"
    			device i2c 5c on end
    		end
+			chip drivers/i2c/hid
+				register "generic.hid" = ""ELAN9050""
+				register "generic.desc" = ""ELAN Touchscreen""
+				register "generic.irq" = "ACPI_IRQ_EDGE_LOW(GPP_D4_IRQ)"
+				register "generic.probed" = "1"
+				register "generic.reset_gpio" =
+							"ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_D5)"
+				register "generic.reset_delay_ms" = "20"
+				register "generic.reset_off_delay_ms" = "2"
+				register "generic.stop_gpio" =
+							"ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_A11)"
+				register "generic.stop_delay_ms" = "280"
+				register "generic.stop_off_delay_ms" = "2"
+				register "generic.enable_gpio" =
+							"ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_D6)"
+				register "generic.enable_delay_ms" = "1"
+				register "generic.has_power_resource" = "1"
+				register "hid_desc_reg_offset" = "0x01"
+				device i2c 15 on end
+			end
    	end # I2C 2
    	device pci 1c.7 on
    		chip drivers/intel/wifi