Change in coreboot[master]: include/device/pci_ids: add model number to ATI GPU and HDA controller
Felix Held has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/47702 )
Change subject: include/device/pci_ids: add model number to ATI GPU and HDA controller ......................................................................
include/device/pci_ids: add model number to ATI GPU and HDA controller
Change-Id: I215058bcb0d53bfec974b8d3721cb4c998fcbee5 Signed-off-by: Felix Held felix-coreboot@felixheld.de --- M src/include/device/pci_ids.h 1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/02/47702/1
diff --git a/src/include/device/pci_ids.h b/src/include/device/pci_ids.h index c8d0c9a..5095f11 100644 --- a/src/include/device/pci_ids.h +++ b/src/include/device/pci_ids.h @@ -477,8 +477,8 @@ #define PCI_DEVICE_ID_AMD_FAM17H_LPC 0x790E #define PCI_DEVICE_ID_AMD_FAM17H_MODEL18H_GBE 0x1458
-#define PCI_DEVICE_ID_ATI_FAM17H_GPU 0x15D8 -#define PCI_DEVICE_ID_ATI_FAM17H_HDA0 0x15DE +#define PCI_DEVICE_ID_ATI_FAM17H_MODEL18H_GPU 0x15D8 +#define PCI_DEVICE_ID_ATI_FAM17H_MODEL18H_HDA0 0x15DE
#define PCI_VENDOR_ID_VLSI 0x1004 #define PCI_DEVICE_ID_VLSI_82C592 0x0005
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/47702
to look at the new patch set (#2).
Change subject: include/device/pci_ids: add model number to ATI GPU and HDA controller ......................................................................
include/device/pci_ids: add model number to ATI GPU and HDA controller
Change-Id: I215058bcb0d53bfec974b8d3721cb4c998fcbee5 Signed-off-by: Felix Held felix-coreboot@felixheld.de --- M src/include/device/pci_ids.h M src/soc/amd/common/block/graphics/graphics.c 2 files changed, 3 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/02/47702/2
Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47702 )
Change subject: include/device/pci_ids: add model number to ATI GPU and HDA controller ......................................................................
Patch Set 2: Code-Review+2
Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/47702 )
Change subject: include/device/pci_ids: add model number to ATI GPU and HDA controller ......................................................................
include/device/pci_ids: add model number to ATI GPU and HDA controller
Change-Id: I215058bcb0d53bfec974b8d3721cb4c998fcbee5 Signed-off-by: Felix Held felix-coreboot@felixheld.de Reviewed-on: https://review.coreboot.org/c/coreboot/+/47702 Reviewed-by: Marshall Dawson marshalldawson3rd@gmail.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/include/device/pci_ids.h M src/soc/amd/common/block/graphics/graphics.c 2 files changed, 3 insertions(+), 3 deletions(-)
Approvals: build bot (Jenkins): Verified Marshall Dawson: Looks good to me, approved
diff --git a/src/include/device/pci_ids.h b/src/include/device/pci_ids.h index c8d0c9a..5095f11 100644 --- a/src/include/device/pci_ids.h +++ b/src/include/device/pci_ids.h @@ -477,8 +477,8 @@ #define PCI_DEVICE_ID_AMD_FAM17H_LPC 0x790E #define PCI_DEVICE_ID_AMD_FAM17H_MODEL18H_GBE 0x1458
-#define PCI_DEVICE_ID_ATI_FAM17H_GPU 0x15D8 -#define PCI_DEVICE_ID_ATI_FAM17H_HDA0 0x15DE +#define PCI_DEVICE_ID_ATI_FAM17H_MODEL18H_GPU 0x15D8 +#define PCI_DEVICE_ID_ATI_FAM17H_MODEL18H_HDA0 0x15DE
#define PCI_VENDOR_ID_VLSI 0x1004 #define PCI_DEVICE_ID_VLSI_82C592 0x0005 diff --git a/src/soc/amd/common/block/graphics/graphics.c b/src/soc/amd/common/block/graphics/graphics.c index d9cdd1a..c2bbff4 100644 --- a/src/soc/amd/common/block/graphics/graphics.c +++ b/src/soc/amd/common/block/graphics/graphics.c @@ -128,7 +128,7 @@ };
static const unsigned short pci_device_ids[] = { - PCI_DEVICE_ID_ATI_FAM17H_GPU, + PCI_DEVICE_ID_ATI_FAM17H_MODEL18H_GPU, 0, };
-
Felix Held (Code Review) -
Marshall Dawson (Code Review)