Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30209 )
Change subject: soc/intel/common/block/lpc: create lpc_get_device() helper function
......................................................................
Patch Set 1:
(3 comments)
https://review.coreboot.org/c/coreboot/+/30209/1/src/soc/intel/common/block/...
File src/soc/intel/common/block/lpc/lpc_lib.c:
https://review.coreboot.org/c/coreboot/+/30209/1/src/soc/intel/common/block/...
PS1, Line 30: PCI_DEV(0, PCI_SLOT(devfn), PCI_FUNC(devfn))
pci_devfn_t is a u32. I don't see why you need a function for this. […]
Ack
https://review.coreboot.org/c/coreboot/+/30209/1/src/soc/intel/common/block/...
PS1, Line 32: PCI_DEV_INVALID
no. […]
Ack
https://review.coreboot.org/c/coreboot/+/30209/1/src/soc/intel/common/block/...
PS1, Line 48: #define LPC_GET_DEV lpc_get_device()
I understand why you want to remove the __SIMPLE_DEVICE__ definition here. […]
Ack
--
To view, visit
https://review.coreboot.org/c/coreboot/+/30209
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I84a6102bf3849e9d4fe28e4c6a11bc7badcf5114
Gerrit-Change-Number: 30209
Gerrit-PatchSet: 1
Gerrit-Owner: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Mon, 17 Feb 2020 06:42:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik
subrata.banik@intel.com
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Gerrit-MessageType: comment