Hello Martin Roth, Furquan Shaikh,
I'd like you to do a code review. Please visit
https://review.coreboot.org/c/coreboot/+/34427
to review the following change.
Change subject: NOT_FOR_MERGE: Make FSP driver tolerate Picasso ......................................................................
NOT_FOR_MERGE: Make FSP driver tolerate Picasso
Change-Id: I24a47a10482486e4755ba8ef18aebc767533905e Signed-off-by: Marshall Dawson marshalldawson3rd@gmail.com --- M src/drivers/intel/fsp2_0/notify.c 1 file changed, 7 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/27/34427/1
diff --git a/src/drivers/intel/fsp2_0/notify.c b/src/drivers/intel/fsp2_0/notify.c index 34d7e89..26258dee 100644 --- a/src/drivers/intel/fsp2_0/notify.c +++ b/src/drivers/intel/fsp2_0/notify.c @@ -69,6 +69,13 @@ { enum fsp_notify_phase phase = (uint32_t)arg;
+ /* Hack for Picasso - we don't currently call fsp-s, and mignt not have + * entry points. W/O this hack, the notification steps find null ptrs + * for the entry point. + */ + if (CONFIG(SOC_AMD_PICASSO)) + return; + display_mtrrs();
fsp_notify(phase);
Marshall Dawson has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/34427 )
Change subject: NOT_FOR_MERGE: Make FSP driver tolerate Picasso ......................................................................
Abandoned
Hack has outlived its usefulness
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34427 )
Change subject: NOT_FOR_MERGE: Make FSP driver tolerate Picasso ......................................................................
Patch Set 5:
(2 comments)
https://review.coreboot.org/c/coreboot/+/34427/5/src/drivers/intel/fsp2_0/no... File src/drivers/intel/fsp2_0/notify.c:
https://review.coreboot.org/c/coreboot/+/34427/5/src/drivers/intel/fsp2_0/no... PS5, Line 72: mignt might
https://review.coreboot.org/c/coreboot/+/34427/5/src/drivers/intel/fsp2_0/no... PS5, Line 75: */ Please use one of the suggested comment styles.
https://doc.coreboot.org/coding_style.html#commenting
Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34427 )
Change subject: NOT_FOR_MERGE: Make FSP driver tolerate Picasso ......................................................................
Patch Set 5:
Paul, I'm sorry you spent time reviewing this patch. It's been abandoned for quite a while, and there is no reason to resurrect it.
Marshall Dawson has removed Martin Roth from this change. ( https://review.coreboot.org/c/coreboot/+/34427 )
Change subject: NOT_FOR_MERGE: Make FSP driver tolerate Picasso ......................................................................
Removed reviewer Martin Roth.
-
Marshall Dawson (Code Review) -
Paul Menzel (Code Review)