Attention is currently required from: Jayvik Desai, Kapil Porwal, Pranava Y N.
Hello Jayvik Desai, Kapil Porwal, Pranava Y N, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/87090?usp=email
to look at the new patch set (#4).
Change subject: mb/google/fatcat: Enable HDA SDI based on FW config ......................................................................
mb/google/fatcat: Enable HDA SDI based on FW config
This commit modifies the handling of PCH High Definition Audio (HDA) Serial Digital Interface (SDI) enablement.
- In `devicetree.cb`, the static `pch_hda_sdi_enable` property is removed to allow varaints to override if needed. - In `variant.c`, `variant_update_soc_memory_init_params` is introduced to dynamically configure `PchHdaSdiEnable` UPD based on the firmware configuration (for example: `AUDIO_ALC256_HDA` or `AUDIO_ALC256M_CG_HDA`). SDI is enabled if this FW config option is present. Otherwise, it defaults to disabled. - `variant.c` is now added for romstage as well because the SDI configuration needs to happen earlier in the boot process.
BUG=b:328770565, b:407876136 TEST=Able to reduce the boot time by 18ms for SKUs w/o HDA audio.
Change-Id: Ice28ea7445a5cb32fe8263ada363d4f45c3152f5 Signed-off-by: Subrata Banik subratabanik@google.com --- M src/mainboard/google/fatcat/variants/baseboard/fatcat/devicetree.cb M src/mainboard/google/fatcat/variants/fatcat/Makefile.mk M src/mainboard/google/fatcat/variants/fatcat/variant.c M src/mainboard/google/fatcat/variants/francka/Makefile.mk A src/mainboard/google/fatcat/variants/francka/variant.c 5 files changed, 32 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/90/87090/4