Subrata Banik has submitted this change. ( https://review.coreboot.org/c/coreboot/+/78049?usp=email )
Change subject: mb/google/rex: Configure ISH UART TX/RX as NC ......................................................................
mb/google/rex: Configure ISH UART TX/RX as NC
This patch reverses ISH UART pin configuration to allow ISH to enter into suspend mode. This UART port is for debugging purposes.
BUG=b:302612549 TEST=On Google/rex platform with ISH enabled, do suspend_stress_test This test must pass
Signed-off-by: Bernardo Perez Priego bernardo.perez.priego@intel.com Change-Id: I8aba45420744a3990e1f9637c3b31ea2e0f78f87 Reviewed-on: https://review.coreboot.org/c/coreboot/+/78049 Reviewed-by: Tanu Malhotra tanu.malhotra@intel.com Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Kapil Porwal kapilporwal@google.com Reviewed-by: Subrata Banik subratabanik@google.com --- M src/mainboard/google/rex/variants/rex0/fw_config.c 1 file changed, 0 insertions(+), 4 deletions(-)
Approvals: build bot (Jenkins): Verified Subrata Banik: Looks good to me, approved Tanu Malhotra: Looks good to me, but someone else must approve Kapil Porwal: Looks good to me, approved
diff --git a/src/mainboard/google/rex/variants/rex0/fw_config.c b/src/mainboard/google/rex/variants/rex0/fw_config.c index cea55ec..35a4fd9 100644 --- a/src/mainboard/google/rex/variants/rex0/fw_config.c +++ b/src/mainboard/google/rex/variants/rex0/fw_config.c @@ -88,10 +88,6 @@ PAD_CFG_NF_IOSTANDBY_IGNORE(GPP_B02, NONE, DEEP, NF3), /* GPP_B03 : ISH_I2C0_SCL */ PAD_CFG_NF_IOSTANDBY_IGNORE(GPP_B03, NONE, DEEP, NF3), - /* GPP_D05 : ISH_UART_TX */ - PAD_CFG_NF(GPP_D05, NONE, DEEP, NF2), - /* GPP_D06 : ISH_UART_RX */ - PAD_CFG_NF(GPP_D06, NONE, DEEP, NF2), /* GPP_B08 : ISH_GP3, SOC_ISH_ACCEL_INT_L */ PAD_CFG_NF(GPP_B08, NONE, DEEP, NF4), /* GPP_E15 : ISH_GP5A, SOC_ISH_IMU_INT_L */