Attention is currently required from: Nico Huber, Tarun Tuli, Martin L Roth, Angel Pons, Andrey Petrov.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69757 )
Change subject: [RFC] Pull ligfxinit in early romstage ......................................................................
Patch Set 2:
(16 comments)
File src/soc/intel/alderlake/romstage/graphics.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-164071): https://review.coreboot.org/c/coreboot/+/69757/comment/1b3debc7_6f459809 PS2, Line 13: struct cpuid_result cp = cpuid_ext(1, 0); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-164071): https://review.coreboot.org/c/coreboot/+/69757/comment/fe784de1_fa2b9190 PS2, Line 16: if (!(cp.ecx & (1 << 6))) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-164071): https://review.coreboot.org/c/coreboot/+/69757/comment/68beda0c_d52e1c31 PS2, Line 16: if (!(cp.ecx & (1 << 6))) suspect code indent for conditional statements (7, 15)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-164071): https://review.coreboot.org/c/coreboot/+/69757/comment/dc60b22e_1fde611a PS2, Line 17: return; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-164071): https://review.coreboot.org/c/coreboot/+/69757/comment/23bf10b9_cecca2e6 PS2, Line 17: return; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-164071): https://review.coreboot.org/c/coreboot/+/69757/comment/0f6a79d9_9c5956c7 PS2, Line 20: if (!(read32((void *)0xfed30010) & 1)) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-164071): https://review.coreboot.org/c/coreboot/+/69757/comment/e5566f3e_14214e00 PS2, Line 20: if (!(read32((void *)0xfed30010) & 1)) suspect code indent for conditional statements (7, 15)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-164071): https://review.coreboot.org/c/coreboot/+/69757/comment/e54881da_185e190f PS2, Line 21: return; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-164071): https://review.coreboot.org/c/coreboot/+/69757/comment/7d0cb6ca_7a90e240 PS2, Line 21: return; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-164071): https://review.coreboot.org/c/coreboot/+/69757/comment/346b0fdb_70e31760 PS2, Line 24: while (!(read8((void *)0xfed40000) & (1 << 7))) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-164071): https://review.coreboot.org/c/coreboot/+/69757/comment/95bd8cbc_89b392cd PS2, Line 24: while (!(read8((void *)0xfed40000) & (1 << 7))) suspect code indent for conditional statements (7, 15)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-164071): https://review.coreboot.org/c/coreboot/+/69757/comment/dcbc4fa7_54b4306e PS2, Line 25: ; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-164071): https://review.coreboot.org/c/coreboot/+/69757/comment/b00cf2e7_674ac7aa PS2, Line 25: ; please, no spaces at the start of a line
File src/soc/intel/common/block/graphics/romstage.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-164071): https://review.coreboot.org/c/coreboot/+/69757/comment/0d90df30_583313ba PS2, Line 27: if (CONFIG(ROMSTAGE_MAINBOARD_USE_LIBGFXINIT)) { code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-164071): https://review.coreboot.org/c/coreboot/+/69757/comment/b03d76dd_ed056cd2 PS2, Line 27: if (CONFIG(ROMSTAGE_MAINBOARD_USE_LIBGFXINIT)) { please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-164071): https://review.coreboot.org/c/coreboot/+/69757/comment/efa4a604_534d5038 PS2, Line 27: if (CONFIG(ROMSTAGE_MAINBOARD_USE_LIBGFXINIT)) { please, no spaces at the start of a line
-
build bot (Jenkins) (Code Review)