Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/19925 )
Change subject: soc/intel/skylake: Add detailed information about PME wake sources ......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/#/c/19925/2/src/soc/intel/skylake/elog.c File src/soc/intel/skylake/elog.c:
Line 54: struct pme_status_info pme_status_info[] = {
static const
Yeah, PCH_DEV_* does dev_find_slot. That's a good idea - I changed it to PCH_DEVFN_* and added check for NULL.
Line 55: {PCH_DEV_HDA, 0x54, ELOG_WAKE_SOURCE_PME_HDA},
spaces after { and before }
Done