Sean Rhodes has submitted this change. ( https://review.coreboot.org/c/coreboot/+/83880?usp=email )
(
8 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: mb/starlabs/starlite_adl: Configure GPIO interrupt for Virtual Button ......................................................................
mb/starlabs/starlite_adl: Configure GPIO interrupt for Virtual Button
Configure GPP_F15 to generate an IRQ, that is used by the Virtual Button driver to report whether the tablet is docked or undocked to the OS.
Change-Id: I0815da09bd7ffd3926622e10df6a06ab5593dc2d Signed-off-by: Sean Rhodes sean@starlabs.systems Reviewed-on: https://review.coreboot.org/c/coreboot/+/83880 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Maxim max.senia.poliak@gmail.com --- M src/mainboard/starlabs/starlite_adl/acpi/mainboard.asl M src/mainboard/starlabs/starlite_adl/variants/mk_v/devicetree.cb M src/mainboard/starlabs/starlite_adl/variants/mk_v/gpio.c 3 files changed, 12 insertions(+), 4 deletions(-)
Approvals: Maxim: Looks good to me, approved build bot (Jenkins): Verified
diff --git a/src/mainboard/starlabs/starlite_adl/acpi/mainboard.asl b/src/mainboard/starlabs/starlite_adl/acpi/mainboard.asl index 34b90af..de4f6f6 100644 --- a/src/mainboard/starlabs/starlite_adl/acpi/mainboard.asl +++ b/src/mainboard/starlabs/starlite_adl/acpi/mainboard.asl @@ -3,3 +3,11 @@ Scope (_SB) { #include "sleep.asl" } + +Scope (_GPE) +{ + Method (_L0F, 0, NotSerialized) + { + _SB.PCI0.LPCB.EC.VBTN.UPDK() + } +} diff --git a/src/mainboard/starlabs/starlite_adl/variants/mk_v/devicetree.cb b/src/mainboard/starlabs/starlite_adl/variants/mk_v/devicetree.cb index 3221d39..02f96f6 100644 --- a/src/mainboard/starlabs/starlite_adl/variants/mk_v/devicetree.cb +++ b/src/mainboard/starlabs/starlite_adl/variants/mk_v/devicetree.cb @@ -22,9 +22,9 @@ register "pch_slp_a_min_assertion_width" = "3" # 2s
# PM Util - register "pmc_gpe0_dw0" = "GPP_A" - register "pmc_gpe0_dw1" = "GPP_R" - register "pmc_gpe0_dw2" = "GPD" + register "pmc_gpe0_dw0" = "PMC_GPP_F" + register "pmc_gpe0_dw1" = "GPP_A" + register "pmc_gpe0_dw2" = "GPP_B"
device domain 0 on device ref igpu on diff --git a/src/mainboard/starlabs/starlite_adl/variants/mk_v/gpio.c b/src/mainboard/starlabs/starlite_adl/variants/mk_v/gpio.c index 9b8bdf2..d026769 100644 --- a/src/mainboard/starlabs/starlite_adl/variants/mk_v/gpio.c +++ b/src/mainboard/starlabs/starlite_adl/variants/mk_v/gpio.c @@ -319,7 +319,7 @@ /* F14: Not Connected */ PAD_NC(GPP_F14, NONE), /* F15: Keyboard Detect */ - PAD_NC(GPP_F15, NONE), + PAD_CFG_GPI_SMI_LOW(GPP_F15, NONE, DEEP, EDGE_BOTH), /* F16: Not Connected */ PAD_NC(GPP_F16, NONE), /* F17: Touch Panel Reset */