Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35680 )
Change subject: cpu/qemu-x86: Add x86_64 bootblock support
......................................................................
Patch Set 8:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35680/8/util/pgtblgen/pgtblgen.c
File util/pgtblgen/pgtblgen.c:
https://review.coreboot.org/c/coreboot/+/35680/8/util/pgtblgen/pgtblgen.c@1
PS8, Line 1: /*
Yes, but that requires a go toolchain, a static csv as input and works for x86_32 only. […]
It can be extended for x86-64. Yes, it does require a go toolchain, but it's better than C for these types of tools, imo. The CSV is helpful since it has a map that can be referenced for inspection at a later date.
I'm not understanding the 'address given as an argument' comment. Could you clarify.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35680
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iec92c6cea464c97c18a0811e2e91bc22133ace42
Gerrit-Change-Number: 35680
Gerrit-PatchSet: 8
Gerrit-Owner: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Alexandru Gagniuc
alexandrux.gagniuc@intel.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Gerd Hoffmann
kraxel@redhat.com
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Lee Leahy
leroy.p.leahy@intel.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: ron minnich
rminnich@gmail.com
Gerrit-CC: Name of user not set #1002476
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 20 Nov 2019 19:25:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Patrick Rudolph
siro@das-labor.org
Comment-In-Reply-To: Aaron Durbin
adurbin@chromium.org
Gerrit-MessageType: comment