Attention is currently required from: Nico Huber, Martin Roth, Angel Pons, Arthur Heymans, Kyösti Mälkki, Patrick Rudolph. Hello build bot (Jenkins), Nico Huber, Patrick Georgi, Martin Roth, Tim Wawrzynczak, Arthur Heymans, Kyösti Mälkki, Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/52520
to look at the new patch set (#4).
Change subject: soc/intel/broadwell/pch: Replace ACPI device NVS ......................................................................
soc/intel/broadwell/pch: Replace ACPI device NVS
The same functionality can be provided through a runtime-generated SSDT. The remaining parts of device NVS are removed in a follow-up.
Since the SSDTs are only loaded after the DSDT (if loaded at all), using SSDT-provided objects outside method bodies is not possible: the objects are not yet in OSPM's ACPI namespace, which causes in ACPI errors. Owing to this, the operation regions used by the _PS0 and _PS3 methods need to be moved into the SSDT, as they depend on the SSDT-provided BAR1 values.
Tested on out-of-tree Compal LA-A992P, generated SSDT disassembles with no errors and contains expected values. Linux does not complain either.
Change-Id: I89fb658fbb10a8769ebea2e6535c45cd7c212d06 Signed-off-by: Angel Pons th3fanbus@gmail.com --- M src/mainboard/google/jecht/dsdt.asl M src/mainboard/intel/wtm2/dsdt.asl D src/soc/intel/broadwell/acpi/device_nvs.asl M src/soc/intel/broadwell/acpi/platform.asl M src/soc/intel/broadwell/include/soc/pch.h M src/soc/intel/broadwell/pch/Makefile.inc A src/soc/intel/broadwell/pch/acpi.c M src/soc/intel/broadwell/pch/acpi/adsp.asl M src/soc/intel/broadwell/pch/acpi/serialio.asl M src/soc/intel/broadwell/pch/lpc.c 10 files changed, 163 insertions(+), 163 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/20/52520/4