Attention is currently required from: Amanda Hwang, Avi Uday, Jayvik Desai, Kapil Porwal, Paul Menzel, Pranava Y N.
Hello Amanda Hwang, Avi Uday, Jayvik Desai, Kapil Porwal, Pranava Y N, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/87463?usp=email
to look at the new patch set (#3).
Change subject: mb/google/fatcat/var/francka: Conditionally init HDA ......................................................................
mb/google/fatcat/var/francka: Conditionally init HDA
This commit implements `mainboard_hda_init()` for the Google Francka mainboard variant. This overrides the default weak HDA common initialization.
Initialization of the High Definition Audio (HDA) controller, managed by `azalia_audio_init()` (which handles HDA verb table loading), is now conditional. It proceeds only if the firmware config `FW_CONFIG(AUDIO, AUDIO_ALC256M_CG_HDA)` is set. This targets the ALC256M-CG HDA codec.
This change ensures that HDA verb tables are loaded only when the ALC256M-CG HDA codec is actively configured for the Francka variant. Crucially, this prevents attempts to incorrectly load HDA verbs for other audio interfaces, like SoundWire (SNDW), which might be present in different Francka hardware configurations.
The headers `device/azalia_device.h` and `intelblocks/hda.h` are added to support this HDA initialization logic.
BUG=b:ENTER_FRANCKA_BUG_ID_HERE TEST=Verified HDA verb table loading is skipped on Francka platforms when configured with non-HDA audio codecs (e.g., SNDW), and proceeds as expected when ALC256M-CG HDA is configured
Change-Id: Idbc506c1ad180c7e8ecdec51c3491e6f0518204c Signed-off-by: Subrata Banik subratabanik@google.com --- M src/mainboard/google/fatcat/variants/francka/variant.c 1 file changed, 8 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/63/87463/3