Change in ...coreboot[master]: vendorcode/eltan/security: Use config VENDORCODE_ELTAN_XXX - coreboot-gerrit - mail.coreboot.org

List overview All Threads
Download

Change in ...coreboot[master]: vendorcode/eltan/security: Use config VENDORCODE_ELTAN_XXX

Change in coreboot[master]: vboot:...

Change in coreboot[master]:...

Frans Hendriks (Code Review)

13 Jun 2019 13 Jun '19

3:03 p.m.

Frans Hendriks has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/33442

Change subject: vendorcode/eltan/security: Use config VENDORCODE_ELTAN_XXX ......................................................................

vendorcode/eltan/security: Use config VENDORCODE_ELTAN_XXX

To avoid confusion use VENDORCODE_ELTAN_VBOOT and VENDORCODE_ELTAN_MBOOT config values.

Inlcude verfied_boot and mboot subdirectories as CPPFLAGS when measured boot or verified boot is enabled. This allows to generate binary with measured boot enabled only.

BUG=N/A TEST=Boot Linux 4.20 and verify logging on Facebook FBG-1701

Change-Id: Iaaf3c8cacbc8d2be7387264ca9c973e583871f0a Signed-off-by: Frans Hendriks fhendriks@eltan.com --- M src/vendorcode/eltan/security/Makefile.inc 1 file changed, 2 insertions(+), 5 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/42/33442/1

diff --git a/src/vendorcode/eltan/security/Makefile.inc b/src/vendorcode/eltan/security/Makefile.inc index 26b324b..16f17fd 100644 --- a/src/vendorcode/eltan/security/Makefile.inc +++ b/src/vendorcode/eltan/security/Makefile.inc @@ -1,6 +1,6 @@ ## This file is part of the coreboot project. ## -## Copyright (C) 2018 Eltan B.V. +## Copyright (C) 2018-2019 Eltan B.V. ## ## This program is free software; you can redistribute it and/or modify ## it under the terms of the GNU General Public License as published by @@ -16,12 +16,9 @@ subdirs-y += verified_boot subdirs-y += mboot

-ifeq ($(CONFIG_MBOOT), y) +ifneq ($(filter y,$(CONFIG_VENDORCODE_ELTAN_VBOOT) $(CONFIG_VENDORCODE_ELTAN_MBOOT)),) CPPFLAGS_common += -I$(src)/vendorcode/eltan/security/mboot CPPFLAGS_common += -I$(src)/vendorcode/eltan/security/include -endif - -ifeq ($(CONFIG_VERIFIED_BOOT), y) CPPFLAGS_common += -I$(src)/vendorcode/eltan/security/verified_boot endif

-- To view, visit https://review.coreboot.org/c/coreboot/+/33442 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iaaf3c8cacbc8d2be7387264ca9c973e583871f0a Gerrit-Change-Number: 33442 Gerrit-PatchSet: 1 Gerrit-Owner: Frans Hendriks fhendriks@eltan.com Gerrit-MessageType: newchange

Attachments:

attachment.htm (text/html — 3.6 KB)

Show replies by date

Frans Hendriks (Code Review)

14 Jun 14 Jun

2:09 p.m.

Hello Patrick Rudolph, David Hendricks, Philipp Deppenwiese, build bot (Jenkins), Patrick Georgi,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/33442

to look at the new patch set (#2).

Change subject: vendorcode/eltan/security: Use config VENDORCODE_ELTAN_XXX ......................................................................

vendorcode/eltan/security: Use config VENDORCODE_ELTAN_XXX

To avoid confusion use VENDORCODE_ELTAN_VBOOT and VENDORCODE_ELTAN_MBOOT config values.

Include verfied_boot and mboot subdirectories as CPPFLAGS when measured boot or verified boot is enabled. This allows to generate binary with measured boot enabled only.

BUG=N/A TEST=Boot Linux 4.20 and verify logging on Facebook FBG-1701

Change-Id: Iaaf3c8cacbc8d2be7387264ca9c973e583871f0a Signed-off-by: Frans Hendriks fhendriks@eltan.com --- M src/vendorcode/eltan/security/Makefile.inc 1 file changed, 2 insertions(+), 5 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/42/33442/2

-- To view, visit https://review.coreboot.org/c/coreboot/+/33442 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iaaf3c8cacbc8d2be7387264ca9c973e583871f0a Gerrit-Change-Number: 33442 Gerrit-PatchSet: 2 Gerrit-Owner: Frans Hendriks fhendriks@eltan.com Gerrit-Reviewer: David Hendricks david.hendricks@gmail.com Gerrit-Reviewer: Frans Hendriks fhendriks@eltan.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Patrick Rudolph patrick.rudolph@9elements.com Gerrit-Reviewer: Philipp Deppenwiese zaolin.daisuki@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: newpatchset

Lance Zhao (Code Review)

3 Aug 3 Aug

1:52 p.m.

New subject: Change in coreboot[master]: vendorcode/eltan/security: Use config VENDORCODE_ELTAN_XXX

Lance Zhao has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33442 )

Change subject: vendorcode/eltan/security: Use config VENDORCODE_ELTAN_XXX ......................................................................

Patch Set 2: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/33442 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iaaf3c8cacbc8d2be7387264ca9c973e583871f0a Gerrit-Change-Number: 33442 Gerrit-PatchSet: 2 Gerrit-Owner: Frans Hendriks fhendriks@eltan.com Gerrit-Reviewer: David Hendricks david.hendricks@gmail.com Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de Gerrit-Reviewer: Frans Hendriks fhendriks@eltan.com Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Lance Zhao lance.zhao@gmail.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Patrick Rudolph patrick.rudolph@9elements.com Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: Philipp Deppenwiese zaolin.daisuki@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Sat, 03 Aug 2019 11:52:28 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Martin Roth (Code Review)

4 Aug 4 Aug

4:55 p.m.

New subject: Change in coreboot[master]: vendorcode/eltan/security: Use config VENDORCODE_ELTAN_XXX

Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33442 )

Change subject: vendorcode/eltan/security: Use config VENDORCODE_ELTAN_XXX ......................................................................

Patch Set 2: Code-Review-1

(1 comment)

-1 to get attention for my comment since it's at +2 now.

https://review.coreboot.org/c/coreboot/+/33442/2/src/vendorcode/eltan/securi... File src/vendorcode/eltan/security/Makefile.inc:

https://review.coreboot.org/c/coreboot/+/33442/2/src/vendorcode/eltan/securi... PS2, Line 19: $(CONFIG_VENDORCODE_ELTAN_VBOOT) $(CONFIG_VENDORCODE_ELTAN_MBOOT) So why not just have one config option? Now if either of these is set, it will do both.

-- To view, visit https://review.coreboot.org/c/coreboot/+/33442 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iaaf3c8cacbc8d2be7387264ca9c973e583871f0a Gerrit-Change-Number: 33442 Gerrit-PatchSet: 2 Gerrit-Owner: Frans Hendriks fhendriks@eltan.com Gerrit-Reviewer: David Hendricks david.hendricks@gmail.com Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de Gerrit-Reviewer: Frans Hendriks fhendriks@eltan.com Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Lance Zhao lance.zhao@gmail.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Patrick Rudolph patrick.rudolph@9elements.com Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: Philipp Deppenwiese zaolin.daisuki@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Sun, 04 Aug 2019 14:55:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Frans Hendriks (Code Review)

5 Aug 5 Aug

2:14 p.m.

New subject: Change in coreboot[master]: vendorcode/eltan/security: Use config VENDORCODE_ELTAN_XXX

Frans Hendriks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33442 )

Change subject: vendorcode/eltan/security: Use config VENDORCODE_ELTAN_XXX ......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/33442/2/src/vendorcode/eltan/securi... File src/vendorcode/eltan/security/Makefile.inc:

https://review.coreboot.org/c/coreboot/+/33442/2/src/vendorcode/eltan/securi... PS2, Line 19: $(CONFIG_VENDORCODE_ELTAN_VBOOT) $(CONFIG_VENDORCODE_ELTAN_MBOOT)

So why not just have one config option? Now if either of these is set, it will do both.

Measured boot can be enabled independ of verified boot. Why to create a new config which indicates that MBOOT and/or VBOOT is enabled.?

-- To view, visit https://review.coreboot.org/c/coreboot/+/33442 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iaaf3c8cacbc8d2be7387264ca9c973e583871f0a Gerrit-Change-Number: 33442 Gerrit-PatchSet: 2 Gerrit-Owner: Frans Hendriks fhendriks@eltan.com Gerrit-Reviewer: David Hendricks david.hendricks@gmail.com Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de Gerrit-Reviewer: Frans Hendriks fhendriks@eltan.com Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Lance Zhao lance.zhao@gmail.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Patrick Rudolph patrick.rudolph@9elements.com Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: Philipp Deppenwiese zaolin.daisuki@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Mon, 05 Aug 2019 12:14:04 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Martin Roth martinroth@google.com Gerrit-MessageType: comment

Martin Roth (Code Review)

8 Aug 8 Aug

5:37 a.m.

New subject: Change in coreboot[master]: vendorcode/eltan/security: Use config VENDORCODE_ELTAN_XXX

Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33442 )

Change subject: vendorcode/eltan/security: Use config VENDORCODE_ELTAN_XXX ......................................................................

Patch Set 2: Code-Review+2

(1 comment)

https://review.coreboot.org/c/coreboot/+/33442/2/src/vendorcode/eltan/securi... File src/vendorcode/eltan/security/Makefile.inc:

https://review.coreboot.org/c/coreboot/+/33442/2/src/vendorcode/eltan/securi... PS2, Line 19: $(CONFIG_VENDORCODE_ELTAN_VBOOT) $(CONFIG_VENDORCODE_ELTAN_MBOOT)

Measured boot can be enabled independ of verified boot. […]

Done

-- To view, visit https://review.coreboot.org/c/coreboot/+/33442 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iaaf3c8cacbc8d2be7387264ca9c973e583871f0a Gerrit-Change-Number: 33442 Gerrit-PatchSet: 2 Gerrit-Owner: Frans Hendriks fhendriks@eltan.com Gerrit-Reviewer: David Hendricks david.hendricks@gmail.com Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de Gerrit-Reviewer: Frans Hendriks fhendriks@eltan.com Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Lance Zhao lance.zhao@gmail.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Patrick Rudolph patrick.rudolph@9elements.com Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: Philipp Deppenwiese zaolin.daisuki@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Thu, 08 Aug 2019 03:37:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Frans Hendriks fhendriks@eltan.com Comment-In-Reply-To: Martin Roth martinroth@google.com Gerrit-MessageType: comment

Martin Roth (Code Review)

5:37 a.m.

New subject: Change in coreboot[master]: vendorcode/eltan/security: Use config VENDORCODE_ELTAN_XXX

Martin Roth has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/33442 )

Change subject: vendorcode/eltan/security: Use config VENDORCODE_ELTAN_XXX ......................................................................

vendorcode/eltan/security: Use config VENDORCODE_ELTAN_XXX

To avoid confusion use VENDORCODE_ELTAN_VBOOT and VENDORCODE_ELTAN_MBOOT config values.

Include verfied_boot and mboot subdirectories as CPPFLAGS when measured boot or verified boot is enabled. This allows to generate binary with measured boot enabled only.

BUG=N/A TEST=Boot Linux 4.20 and verify logging on Facebook FBG-1701

Change-Id: Iaaf3c8cacbc8d2be7387264ca9c973e583871f0a Signed-off-by: Frans Hendriks fhendriks@eltan.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/33442 Reviewed-by: Lance Zhao lance.zhao@gmail.com Reviewed-by: Martin Roth martinroth@google.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/vendorcode/eltan/security/Makefile.inc 1 file changed, 2 insertions(+), 5 deletions(-)

Approvals: build bot (Jenkins): Verified Martin Roth: Looks good to me, approved Lance Zhao: Looks good to me, approved

diff --git a/src/vendorcode/eltan/security/Makefile.inc b/src/vendorcode/eltan/security/Makefile.inc index 26b324b..16f17fd 100644 --- a/src/vendorcode/eltan/security/Makefile.inc +++ b/src/vendorcode/eltan/security/Makefile.inc @@ -1,6 +1,6 @@ ## This file is part of the coreboot project. ## -## Copyright (C) 2018 Eltan B.V. +## Copyright (C) 2018-2019 Eltan B.V. ## ## This program is free software; you can redistribute it and/or modify ## it under the terms of the GNU General Public License as published by @@ -16,12 +16,9 @@ subdirs-y += verified_boot subdirs-y += mboot

-ifeq ($(CONFIG_MBOOT), y) +ifneq ($(filter y,$(CONFIG_VENDORCODE_ELTAN_VBOOT) $(CONFIG_VENDORCODE_ELTAN_MBOOT)),) CPPFLAGS_common += -I$(src)/vendorcode/eltan/security/mboot CPPFLAGS_common += -I$(src)/vendorcode/eltan/security/include -endif - -ifeq ($(CONFIG_VERIFIED_BOOT), y) CPPFLAGS_common += -I$(src)/vendorcode/eltan/security/verified_boot endif

-- To view, visit https://review.coreboot.org/c/coreboot/+/33442 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iaaf3c8cacbc8d2be7387264ca9c973e583871f0a Gerrit-Change-Number: 33442 Gerrit-PatchSet: 3 Gerrit-Owner: Frans Hendriks fhendriks@eltan.com Gerrit-Reviewer: David Hendricks david.hendricks@gmail.com Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de Gerrit-Reviewer: Frans Hendriks fhendriks@eltan.com Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Lance Zhao lance.zhao@gmail.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Patrick Rudolph patrick.rudolph@9elements.com Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: Philipp Deppenwiese zaolin.daisuki@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: merged

Kyösti Mälkki (Code Review)

26 Sep 26 Sep

2:08 a.m.

New subject: Change in coreboot[master]: vendorcode/eltan/security: Use config VENDORCODE_ELTAN_XXX

Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33442 )

Change subject: vendorcode/eltan/security: Use config VENDORCODE_ELTAN_XXX ......................................................................

Patch Set 3:

(3 comments)

What's the complete picture here? I see Kconfig variables that are not defined and directories that do not exist?

https://review.coreboot.org/c/coreboot/+/33442/3/src/vendorcode/eltan/securi... File src/vendorcode/eltan/security/Makefile.inc:

https://review.coreboot.org/c/coreboot/+/33442/3/src/vendorcode/eltan/securi... PS3, Line 17: subdirs-y += mboot No such directory? (last two)

https://review.coreboot.org/c/coreboot/+/33442/3/src/vendorcode/eltan/securi... PS3, Line 19: ifneq ($(filter y,$(CONFIG_VENDORCODE_ELTAN_VBOOT) $(CONFIG_VENDORCODE_ELTAN_MBOOT)),) No such Kconfig defined?

https://review.coreboot.org/c/coreboot/+/33442/3/src/vendorcode/eltan/securi... PS3, Line 26: CPPFLAGS_common += -I$(src)/security/include No such directory?

-- To view, visit https://review.coreboot.org/c/coreboot/+/33442 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iaaf3c8cacbc8d2be7387264ca9c973e583871f0a Gerrit-Change-Number: 33442 Gerrit-PatchSet: 3 Gerrit-Owner: Frans Hendriks fhendriks@eltan.com Gerrit-Reviewer: David Hendricks david.hendricks@gmail.com Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de Gerrit-Reviewer: Frans Hendriks fhendriks@eltan.com Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Julius Werner jwerner@chromium.org Gerrit-Reviewer: Lance Zhao lance.zhao@gmail.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Patrick Rudolph patrick.rudolph@9elements.com Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: Philipp Deppenwiese zaolin.daisuki@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Kyösti Mälkki kyosti.malkki@gmail.com Gerrit-Comment-Date: Thu, 26 Sep 2019 00:08:56 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Frans Hendriks (Code Review)

4:03 p.m.

New subject: Change in coreboot[master]: vendorcode/eltan/security: Use config VENDORCODE_ELTAN_XXX

Frans Hendriks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33442 )

Change subject: vendorcode/eltan/security: Use config VENDORCODE_ELTAN_XXX ......................................................................

Patch Set 3:

(3 comments)

https://review.coreboot.org/c/coreboot/+/33442/3/src/vendorcode/eltan/securi... File src/vendorcode/eltan/security/Makefile.inc:

https://review.coreboot.org/c/coreboot/+/33442/3/src/vendorcode/eltan/securi... PS3, Line 17: subdirs-y += mboot

No such directory? (last two)

Is in other patch set

https://review.coreboot.org/c/coreboot/+/33442/3/src/vendorcode/eltan/securi... PS3, Line 19: ifneq ($(filter y,$(CONFIG_VENDORCODE_ELTAN_VBOOT) $(CONFIG_VENDORCODE_ELTAN_MBOOT)),)

No such Kconfig defined?

Is in other patch set

https://review.coreboot.org/c/coreboot/+/33442/3/src/vendorcode/eltan/securi... PS3, Line 26: CPPFLAGS_common += -I$(src)/security/include

No such directory?

Is in other patch set

-- To view, visit https://review.coreboot.org/c/coreboot/+/33442 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iaaf3c8cacbc8d2be7387264ca9c973e583871f0a Gerrit-Change-Number: 33442 Gerrit-PatchSet: 3 Gerrit-Owner: Frans Hendriks fhendriks@eltan.com Gerrit-Reviewer: David Hendricks david.hendricks@gmail.com Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de Gerrit-Reviewer: Frans Hendriks fhendriks@eltan.com Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Julius Werner jwerner@chromium.org Gerrit-Reviewer: Lance Zhao lance.zhao@gmail.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Patrick Rudolph patrick.rudolph@9elements.com Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: Philipp Deppenwiese zaolin.daisuki@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Kyösti Mälkki kyosti.malkki@gmail.com Gerrit-Comment-Date: Thu, 26 Sep 2019 14:03:49 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Kyösti Mälkki kyosti.malkki@gmail.com Gerrit-MessageType: comment

Kyösti Mälkki (Code Review)

5:47 p.m.

New subject: Change in coreboot[master]: vendorcode/eltan/security: Use config VENDORCODE_ELTAN_XXX

Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33442 )

Change subject: vendorcode/eltan/security: Use config VENDORCODE_ELTAN_XXX ......................................................................

Patch Set 3:

Thanks.. So this was just merged out-of-order and the work that was supposed to go in first has not been merged for 6 weeks.

-- To view, visit https://review.coreboot.org/c/coreboot/+/33442 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iaaf3c8cacbc8d2be7387264ca9c973e583871f0a Gerrit-Change-Number: 33442 Gerrit-PatchSet: 3 Gerrit-Owner: Frans Hendriks fhendriks@eltan.com Gerrit-Reviewer: David Hendricks david.hendricks@gmail.com Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de Gerrit-Reviewer: Frans Hendriks fhendriks@eltan.com Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Julius Werner jwerner@chromium.org Gerrit-Reviewer: Lance Zhao lance.zhao@gmail.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Patrick Rudolph patrick.rudolph@9elements.com Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: Philipp Deppenwiese zaolin.daisuki@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Kyösti Mälkki kyosti.malkki@gmail.com Gerrit-Comment-Date: Thu, 26 Sep 2019 15:47:03 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Frans Hendriks (Code Review)

27 Sep 27 Sep

11:12 a.m.

New subject: Change in coreboot[master]: vendorcode/eltan/security: Use config VENDORCODE_ELTAN_XXX

Frans Hendriks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33442 )

Change subject: vendorcode/eltan/security: Use config VENDORCODE_ELTAN_XXX ......................................................................

Patch Set 3:

Patch Set 3:

Thanks.. So this was just merged out-of-order and the work that was supposed to go in first has not been merged for 6 weeks.

Other patches are still waiting for review (have +1 already ....

-- To view, visit https://review.coreboot.org/c/coreboot/+/33442 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iaaf3c8cacbc8d2be7387264ca9c973e583871f0a Gerrit-Change-Number: 33442 Gerrit-PatchSet: 3 Gerrit-Owner: Frans Hendriks fhendriks@eltan.com Gerrit-Reviewer: David Hendricks david.hendricks@gmail.com Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de Gerrit-Reviewer: Frans Hendriks fhendriks@eltan.com Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Julius Werner jwerner@chromium.org Gerrit-Reviewer: Lance Zhao lance.zhao@gmail.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Patrick Rudolph patrick.rudolph@9elements.com Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: Philipp Deppenwiese zaolin.daisuki@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Kyösti Mälkki kyosti.malkki@gmail.com Gerrit-Comment-Date: Fri, 27 Sep 2019 09:12:39 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1823

days inactive

1929

days old

coreboot-gerrit@coreboot.org

10 comments

4 participants

tags (0)

participants (4)

Frans Hendriks (Code Review)
Kyösti Mälkki (Code Review)
Lance Zhao (Code Review)
Martin Roth (Code Review)