Change in coreboot[master]: Herobrine: sc7280: Add support for audio - coreboot-gerrit

23 Dec 2021


      Attention is currently required from: Ravi kumar, Sudheer Amrabadi.
Shelley Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57449 )
Change subject: Herobrine: sc7280: Add support for audio
......................................................................
Patch Set 30:
(1 comment)
File src/mainboard/google/herobrine/board.h:
https://review.coreboot.org/c/coreboot/+/57449/comment/b5535373_99eda748 
PS30, Line 33: 
             : #if CONFIG(BOARD_GOOGLE_HEROBRINE)
             : #define USB_HUB_LDO_EN		GPIO(24)
             : #elif CONFIG(BOARD_GOOGLE_SENOR) || CONFIG(BOARD_GOOGLE_PIGLIN) || CONFIG(BOARD_GOOGLE_HOGLIN)
             : #define USB_HUB_LDO_EN		GPIO(157)
             : #endif
Isn't this for USB?  Why is this in the audio patch?
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/57449
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2ce95332f892d5d4acb2755307df84d37feb8002
Gerrit-Change-Number: 57449
Gerrit-PatchSet: 30
Gerrit-Owner: Ravi kumar rbokka@codeaurora.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-CC: Ravi Kumar Bokka c_rbokka@qualcomm.corp-partner.google.com
Gerrit-CC: Shelley Chen shchen@google.com
Gerrit-CC: Sudheer Amrabadi samrabad@codeaurora.org
Gerrit-Attention: Ravi kumar rbokka@codeaurora.org
Gerrit-Attention: Sudheer Amrabadi samrabad@codeaurora.org
Gerrit-Comment-Date: Wed, 22 Dec 2021 23:10:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment