Attention is currently required from: Aseda Aboagye, Caveh Jalali, Cliff Huang, Forest Mittelberg, Lance Zhao, Tim Wawrzynczak.
Jonathon Hall has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81996?usp=email )
Change subject: acpigen_ps2_keybd: Add assistant to linux,keymap
......................................................................
Patch Set 3:
(1 comment)
File src/ec/google/chromeec/ec_acpi.c:
https://review.coreboot.org/c/coreboot/+/81996/comment/ec26b04d_93ec585f :
PS3, Line 256: true);
This doesn't match the order of parameters in the function. If the EC says it doesn't have an assistant key, it'll actually disable the alpha/num/punct keys.
IMO it makes sense to keep the "specific keys" together and put alpha/num/punct last, so maybe change the order of parameters in the function.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/81996?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I217220e89bce88e3045a4fc3b124954696276442
Gerrit-Change-Number: 81996
Gerrit-PatchSet: 3
Gerrit-Owner: Aseda Aboagye
aaboagye@google.com
Gerrit-Reviewer: Caveh Jalali
caveh@chromium.org
Gerrit-Reviewer: Cliff Huang
cliff.huang@intel.com
Gerrit-Reviewer: Forest Mittelberg
bmbm@google.com
Gerrit-Reviewer: Jonathon Hall
jonathon.hall@puri.sm
Gerrit-Reviewer: Lance Zhao
lance.zhao@gmail.com
Gerrit-Reviewer: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-CC: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Lance Zhao
lance.zhao@gmail.com
Gerrit-Attention: Cliff Huang
cliff.huang@intel.com
Gerrit-Attention: Caveh Jalali
caveh@chromium.org
Gerrit-Attention: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Attention: Aseda Aboagye
aaboagye@google.com
Gerrit-Attention: Forest Mittelberg
bmbm@google.com
Gerrit-Comment-Date: Thu, 18 Apr 2024 18:56:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment