Attention is currently required from: Aseda Aboagye, Caveh Jalali, Cliff Huang, Forest Mittelberg, Lance Zhao, Tim Wawrzynczak.

View Change

1 comment:

• File src/ec/google/chromeec/ec_acpi.c:

  • Patch Set #3, Line 256: true);

    This doesn't match the order of parameters in the function. If the EC says it doesn't have an assistant key, it'll actually disable the alpha/num/punct keys.

    IMO it makes sense to keep the "specific keys" together and put alpha/num/punct last, so maybe change the order of parameters in the function.

To view, visit change 81996. To unsubscribe, or for help writing mail filters, visit settings.