Change in ...coreboot[master]: drivers/intel/fsp1_0/fastboot_cache: Remove unneeded 'else'

[HAOUAS Elyes (Code Review)]

HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/33332

Change subject: drivers/intel/fsp1_0/fastboot_cache: Remove unneeded 'else'
......................................................................

drivers/intel/fsp1_0/fastboot_cache: Remove unneeded 'else'

'else' is not needed after a 'break' or 'return'.

Change-Id: I109f5aaa87afde61a36fff884305b43c1de2c680
Signed-off-by: Elyes HAOUAS 
---
M src/drivers/intel/fsp1_0/fastboot_cache.c
1 file changed, 5 insertions(+), 6 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/32/33332/1

diff --git a/src/drivers/intel/fsp1_0/fastboot_cache.c b/src/drivers/intel/fsp1_0/fastboot_cache.c
index 088c292..34761a0 100644
--- a/src/drivers/intel/fsp1_0/fastboot_cache.c
+++ b/src/drivers/intel/fsp1_0/fastboot_cache.c
@@ -65,13 +65,12 @@
    	}
    	*mrc_region_ptr = NULL;
    	return 0;
-	} else {
-		*mrc_region_ptr = cbfs_boot_map_with_leak("mrc.cache",
-							CBFS_TYPE_MRC_CACHE,
-							&region_size);
-
-		return region_size;
    }
+	*mrc_region_ptr = cbfs_boot_map_with_leak("mrc.cache",
+						CBFS_TYPE_MRC_CACHE,
+						&region_size);
+
+	return region_size;
 }

/*

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33332 )

Change subject: drivers/intel/fsp1_0/fastboot_cache: Remove unneeded 'else'
......................................................................

Patch Set 1: Code-Review+2

[Patrick Georgi (Code Review)]

Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/33332 )

Change subject: drivers/intel/fsp1_0/fastboot_cache: Remove unneeded 'else'
......................................................................

drivers/intel/fsp1_0/fastboot_cache: Remove unneeded 'else'

'else' is not needed after a 'break' or 'return'.

Change-Id: I109f5aaa87afde61a36fff884305b43c1de2c680
Signed-off-by: Elyes HAOUAS 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/33332
Tested-by: build bot (Jenkins) 
Reviewed-by: Vlado Cibic
Reviewed-by: Angel Pons 
---
M src/drivers/intel/fsp1_0/fastboot_cache.c
1 file changed, 5 insertions(+), 6 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Angel Pons: Looks good to me, approved
  Vlado Cibic: Looks good to me, but someone else must approve

diff --git a/src/drivers/intel/fsp1_0/fastboot_cache.c b/src/drivers/intel/fsp1_0/fastboot_cache.c
index 088c292..34761a0 100644
--- a/src/drivers/intel/fsp1_0/fastboot_cache.c
+++ b/src/drivers/intel/fsp1_0/fastboot_cache.c
@@ -65,13 +65,12 @@
    	}
    	*mrc_region_ptr = NULL;
    	return 0;
-	} else {
-		*mrc_region_ptr = cbfs_boot_map_with_leak("mrc.cache",
-							CBFS_TYPE_MRC_CACHE,
-							&region_size);
-
-		return region_size;
    }
+	*mrc_region_ptr = cbfs_boot_map_with_leak("mrc.cache",
+						CBFS_TYPE_MRC_CACHE,
+						&region_size);
+
+	return region_size;
 }

/*