Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30500 )
Change subject: [WIP]arch/x86/postcar: Add x86_64 support
......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/#/c/30500/3/src/arch/x86/gdt_init.S
File src/arch/x86/gdt_init.S:
https://review.coreboot.org/#/c/30500/3/src/arch/x86/gdt_init.S@42
PS3, Line 42: /* selgdt 0, unused */
It is, as gdt moved the struct at gdtptr can no longer be used as dummy. […]
Well.. removal of the hack happens regardless of x86_64 and can be done separately.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/30500
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1c190627f5f0ed6f82738cb99423892382899d7b
Gerrit-Change-Number: 30500
Gerrit-PatchSet: 3
Gerrit-Owner: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 01 Mar 2019 09:32:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Kyösti Mälkki
kyosti.malkki@gmail.com
Comment-In-Reply-To: Patrick Rudolph
siro@das-labor.org
Gerrit-MessageType: comment