Attention is currently required from: Arthur Heymans.
Bill XIE has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74180 )
Change subject: nb/intel/gm45: Export EDID-reading routine as a function ......................................................................
Patch Set 4:
(2 comments)
File src/northbridge/intel/gm45/gm45.h:
https://review.coreboot.org/c/coreboot/+/74180/comment/7d4ef395_61ba00e1 PS3, Line 452: get_edid_str
nit: as this has a bigger scope now, maybe call it gm45_get_lvds_edid_str ?
Done
File src/northbridge/intel/gm45/gma.c:
https://review.coreboot.org/c/coreboot/+/74180/comment/1634f4fb_c4c5b49f PS3, Line 160: /* : * GTT base is at a 2M offset and is 2M big. If GTT is smaller than 2M : * cycles are simply not decoded which is fine. : */ : pci_or_config16(dev, PCI_COMMAND, PCI_COMMAND_MASTER); : memset(mmio + 2 * MiB, 0, 2 * MiB);
Where should it be put?
In gma_func0_init() like this?