Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48801 )
Change subject: mb/clevo/cml-u: move gpio early init to bootblock_mainboard_early_init ......................................................................
Patch Set 3: Code-Review-1
(1 comment)
https://review.coreboot.org/c/coreboot/+/48801/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/48801/2//COMMIT_MSG@10 PS2, Line 10: after gpio configuration in : common code got dropped.
There is no need to merge this patch before that
- does not hurt, 2. see above
It _does_ hurt, because if that's the case it just makes the commit message wrong and misleading, if this change should be merged before the common GPIO code changes.
There is no need to merge this patch before that
Fine. Then please rebase on your changes to make the relation clear. I'm out here.