Attention is currently required from: Maximilian Brune.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80180?usp=email )
Change subject: drivers/uart/pl011: Enhance struct documentation ......................................................................
Patch Set 1: Code-Review+1
(2 comments)
File src/drivers/uart/pl011.h:
https://review.coreboot.org/c/coreboot/+/80180/comment/ac48949d_e3dd7dec : PS1, Line 15: u32 ilpr; // offset: 0x20 Low-Power Counter Register The `i' seems to be for IrDA specifically, so please mention.
https://review.coreboot.org/c/coreboot/+/80180/comment/1a16db5f_c88ee28e : PS1, Line 34: u32 cellid3; // offset: 0xFFC UART CellID3 Register Maybe it's just me, but I wouldn't repeat "Register" on every line.