Attention is currently required from: Anil Kumar K, Dinesh Gehlot, Eran Mitrani, Kapil Porwal, Martin L Roth, Martin Roth, Paul Menzel, Pratikkumar V Prajapati, Shelley Chen, Subrata Banik, Tarun.
Jérémy Compostella has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78244?usp=email )
Change subject: soc/intel/mtl: Display Sign-of-Life message using FSP-M ......................................................................
Patch Set 23:
(6 comments)
File src/soc/intel/meteorlake/Kconfig:
https://review.coreboot.org/c/coreboot/+/78244/comment/a7d5324c_84fcfe5d : PS23, Line 463: depends on MAINBOARD_HAS_CHROMEOS
Why this dependency?
Because on Meteor Lake, the PEIM graphics driver is only available to the chrome OS program. The new commit message reflects this.
https://review.coreboot.org/c/coreboot/+/78244/comment/c8ba5cc7_deb00a46 : PS23, Line 464: select VBT_CBFS_COMPRESSION_DEFAULT_LZ4
Why?
Because by default LZMA compression algorithn is not available in romstage. Adding the support of LZMA in romstage undermine the benefit of compressing VBT with LZMA.
https://review.coreboot.org/c/coreboot/+/78244/comment/45c410ae_f2ebc85d : PS23, Line 466: which display
- which display*s* […]
Done
https://review.coreboot.org/c/coreboot/+/78244/comment/c132965e_813b0f76 : PS23, Line 467: Memory
memory
Done
https://review.coreboot.org/c/coreboot/+/78244/comment/451db51d_ea46bd15 : PS23, Line 467: configurable text message
Where can this be configured?
I updated the commit message to provide this information.
https://review.coreboot.org/c/coreboot/+/78244/comment/3e9d3da0_fe454f6a : PS23, Line 468: and CSME update.
It’d be nice, if you added as much information how the FSP-M graphics init works either here in the […]
I added details in the commit message.
-
Jérémy Compostella (Code Review)