Patrick Rudolph has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/32889
Change subject: Documentation: Warn about ME cleaner on Sandy Bridge ......................................................................
Documentation: Warn about ME cleaner on Sandy Bridge
Document known issues with 'disabled' ME.
Change-Id: I364f3ed49341523c781eb2f3b41e866f33632a7e Signed-off-by: Patrick Rudolph patrick.rudolph@9elements.com --- M Documentation/northbridge/intel/sandybridge/index.md A Documentation/northbridge/intel/sandybridge/me_cleaner.md 2 files changed, 13 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/89/32889/1
diff --git a/Documentation/northbridge/intel/sandybridge/index.md b/Documentation/northbridge/intel/sandybridge/index.md index dcb090a..c1d4b99 100644 --- a/Documentation/northbridge/intel/sandybridge/index.md +++ b/Documentation/northbridge/intel/sandybridge/index.md @@ -6,3 +6,4 @@
- [Native Ram Initialization](nri.md) - [RAM initialization feature matrix](nri_features.md) +- [ME Cleaner](me_cleaner.md) diff --git a/Documentation/northbridge/intel/sandybridge/me_cleaner.md b/Documentation/northbridge/intel/sandybridge/me_cleaner.md new file mode 100644 index 0000000..25938a5 --- /dev/null +++ b/Documentation/northbridge/intel/sandybridge/me_cleaner.md @@ -0,0 +1,12 @@ +# ME Cleaner +It's possible to 'clean' the ME partition within the flash medium as part +of the build process. Using a 'cleaned' ME partition is *not* +recommomended. + +## Observations with 'cleaned' ME + +* Instable LPC bus + * SuperIO is malfunctioning + * TPM is malfunctioning + * Random system shutdowns on high bus activity +
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32889 )
Change subject: Documentation: Warn about ME cleaner on Sandy Bridge ......................................................................
Patch Set 1:
maybe add a sentence what me_cleaner does? from the text it isn't obvious what "cleaning" the me image does, so i'd add that this will remove as much code as it can from the me image
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32889 )
Change subject: Documentation: Warn about ME cleaner on Sandy Bridge ......................................................................
Patch Set 1:
Patch Set 1:
maybe add a sentence what me_cleaner does? from the text it isn't obvious what "cleaning" the me image does, so i'd add that this will remove as much code as it can from the me image
I'd also add that the ME errors when said code is removed, which is an abnormal state.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32889 )
Change subject: Documentation: Warn about ME cleaner on Sandy Bridge ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/#/c/32889/1/Documentation/northbridge/intel/sand... File Documentation/northbridge/intel/sandybridge/me_cleaner.md:
https://review.coreboot.org/#/c/32889/1/Documentation/northbridge/intel/sand... PS1, Line 4: recommomended recommended
https://review.coreboot.org/#/c/32889/1/Documentation/northbridge/intel/sand... PS1, Line 12: Please remove the blank line at the end of the file.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32889 )
Change subject: Documentation: Warn about ME cleaner on Sandy Bridge ......................................................................
Patch Set 1:
i wonder if this is a sandy bridge vs. ivy bridge thing or rather a cougar point vs. panther point issue; i'd say the latter
Hello Angel Pons, Arthur Heymans, Nicola Corna, build bot (Jenkins), Nico Huber,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/32889
to look at the new patch set (#2).
Change subject: Documentation: Warn about ME cleaner on Sandy Bridge ......................................................................
Documentation: Warn about ME cleaner on Sandy Bridge
Document known issues with 'disabled' ME.
Change-Id: I364f3ed49341523c781eb2f3b41e866f33632a7e Signed-off-by: Patrick Rudolph patrick.rudolph@9elements.com --- M Documentation/northbridge/intel/sandybridge/index.md A Documentation/northbridge/intel/sandybridge/me_cleaner.md 2 files changed, 15 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/89/32889/2
Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32889 )
Change subject: Documentation: Warn about ME cleaner on Sandy Bridge ......................................................................
Patch Set 2:
(2 comments)
Patch Set 1:
Patch Set 1:
maybe add a sentence what me_cleaner does? from the text it isn't obvious what "cleaning" the me image does, so i'd add that this will remove as much code as it can from the me image
I'd also add that the ME errors when said code is removed, which is an abnormal state.
Done
https://review.coreboot.org/#/c/32889/1/Documentation/northbridge/intel/sand... File Documentation/northbridge/intel/sandybridge/me_cleaner.md:
https://review.coreboot.org/#/c/32889/1/Documentation/northbridge/intel/sand... PS1, Line 4: recommomended
recommended
Done
https://review.coreboot.org/#/c/32889/1/Documentation/northbridge/intel/sand... PS1, Line 12:
Please remove the blank line at the end of the file.
Done
Nicola Corna has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32889 )
Change subject: Documentation: Warn about ME cleaner on Sandy Bridge ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/#/c/32889/2/Documentation/northbridge/intel/sand... File Documentation/northbridge/intel/sandybridge/me_cleaner.md:
https://review.coreboot.org/#/c/32889/2/Documentation/northbridge/intel/sand... PS2, Line 7: Using a 'cleaned' ME partition is *not* recommended. Maybe I'm just biased towards my script, but isn't this line a bit too definitive? I mean, on my machines (one Sandy Bridge laptop, one Ivy Bridge laptop and one Ivy Bridge desktop) everything works wonderfully, even with a crippled ME.
I'd suggest something like: "Using a 'cleaned' ME partition may lead to issues: its use should be carefully evaulated."
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32889 )
Change subject: Documentation: Warn about ME cleaner on Sandy Bridge ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/#/c/32889/2/Documentation/northbridge/intel/sand... File Documentation/northbridge/intel/sandybridge/me_cleaner.md:
https://review.coreboot.org/#/c/32889/2/Documentation/northbridge/intel/sand... PS2, Line 7: Using a 'cleaned' ME partition is *not* recommended.
Maybe I'm just biased towards my script, but isn't this line a bit too definitive? I mean, on my mac […]
maybe also add not to file bug reports about weird issues when not having tested with the unmodified ifd and me section? if it works well enough for people, i don't see much reason to strongly advise against that, but since it might cause hard to debug problems, i wouldn't advise to use it by default for all users. i like that the users have the option to use me_cleaner, but i definitely wouldn't advertise it as "just check that box and everything will be great"; it's more like "only check this box if you really want that and you're aware that it might cause weird problems"
Patrick Rudolph has uploaded a new patch set (#4) to the change originally created by Patrick Rudolph. ( https://review.coreboot.org/c/coreboot/+/32889 )
Change subject: Documentation: Warn about ME cleaner on Sandy Bridge ......................................................................
Documentation: Warn about ME cleaner on Sandy Bridge
Document known issues with 'disabled' ME.
Change-Id: I364f3ed49341523c781eb2f3b41e866f33632a7e Signed-off-by: Patrick Rudolph patrick.rudolph@9elements.com --- M Documentation/northbridge/intel/sandybridge/index.md A Documentation/northbridge/intel/sandybridge/me_cleaner.md 2 files changed, 21 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/89/32889/4
Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32889 )
Change subject: Documentation: Warn about ME cleaner on Sandy Bridge ......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/#/c/32889/2/Documentation/northbridge/intel/sand... File Documentation/northbridge/intel/sandybridge/me_cleaner.md:
https://review.coreboot.org/#/c/32889/2/Documentation/northbridge/intel/sand... PS2, Line 7: Using a 'cleaned' ME partition is *not* recommended.
maybe also add not to file bug reports about weird issues when not having tested with the unmodified […]
Done
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32889 )
Change subject: Documentation: Warn about ME cleaner on Sandy Bridge ......................................................................
Patch Set 4: Code-Review+2
Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/32889 )
Change subject: Documentation: Warn about ME cleaner on Sandy Bridge ......................................................................
Documentation: Warn about ME cleaner on Sandy Bridge
Document known issues with 'disabled' ME.
Change-Id: I364f3ed49341523c781eb2f3b41e866f33632a7e Signed-off-by: Patrick Rudolph patrick.rudolph@9elements.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/32889 Reviewed-by: Felix Held felix-coreboot@felixheld.de Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M Documentation/northbridge/intel/sandybridge/index.md A Documentation/northbridge/intel/sandybridge/me_cleaner.md 2 files changed, 21 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Felix Held: Looks good to me, approved
diff --git a/Documentation/northbridge/intel/sandybridge/index.md b/Documentation/northbridge/intel/sandybridge/index.md index dcb090a..c1d4b99 100644 --- a/Documentation/northbridge/intel/sandybridge/index.md +++ b/Documentation/northbridge/intel/sandybridge/index.md @@ -6,3 +6,4 @@
- [Native Ram Initialization](nri.md) - [RAM initialization feature matrix](nri_features.md) +- [ME Cleaner](me_cleaner.md) diff --git a/Documentation/northbridge/intel/sandybridge/me_cleaner.md b/Documentation/northbridge/intel/sandybridge/me_cleaner.md new file mode 100644 index 0000000..1086e7e --- /dev/null +++ b/Documentation/northbridge/intel/sandybridge/me_cleaner.md @@ -0,0 +1,20 @@ +# ME Cleaner +It's possible to 'clean' the ME partition within the flash medium as part +of the build process. While cleaning as much code as possible is removed +from the ME firmware partition. In this state the ME errors out and doesn't +operate any more. + +**Using a 'cleaned' ME partition may lead to issues and its use should be +carefully evaulated.** + +## Observations with 'cleaned' ME + +* Instable LPC bus + * SuperIO is malfunctioning + * TPM is malfunctioning + * Random system shutdowns on high bus activity + +## Filing bug reports + +Always test with unmodified IFD and ME section before reporting bugs to the +coreboot project.
-
Angel Pons (Code Review) -
Felix Held (Code Review)
-
Nicola Corna (Code Review)
-
Patrick Georgi (Code Review)
-
Patrick Rudolph (Code Review)
-
Paul Menzel (Code Review)