Attention is currently required from: Felix Singer, Martin L Roth, Paul Menzel.
Tim Crawford has posted comments on this change by Tim Crawford. ( https://review.coreboot.org/c/coreboot/+/82788?usp=email )
Change subject: mb/system76/mtl: Add Lemur Pro 13 ......................................................................
Patch Set 7:
(4 comments)
File src/mainboard/system76/mtl/Makefile.mk:
https://review.coreboot.org/c/coreboot/+/82788/comment/9cd578d2_94469fdd?usp... : PS5, Line 16: SPD_SOURCES = samsung-M425R1GB4BB0-CQKOD samsung-M425R1GB4PB0-CWMOD
Is it intended to add the SPD files to all variants?
Since Lemur is our only model with onboard memory, yes.
File src/mainboard/system76/mtl/variants/lemp13/board.fmd:
PS5:
That looks like a standard coreboot FMAP. […]
We have a downstream patch that locks regions, so we explicitly declare the layout in FMD files, rather than relying on what `CBFS_SIZE` generates.
File src/mainboard/system76/mtl/variants/lemp13/gpio.c:
PS5:
For completeness, could you add comments to the rest of the used GPIOs as well?
Done
File src/mainboard/system76/mtl/variants/lemp13/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/82788/comment/1bf79fb0_922742cd?usp... : PS5, Line 86: CARD
That probably means card reader?
Yes.
-
Tim Crawford (Code Review)