[L] Change in coreboot[main]: mb/google/dedede: Create dita variant - coreboot-gerrit

31 Dec 2023


      Attention is currently required from: Lucas Chen, Sheng-Liang Pan.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79655?usp=email )
Change subject: mb/google/dedede: Create dita variant
......................................................................
Patch Set 3:
(1 comment)
File src/mainboard/google/dedede/variants/dita/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/79655/comment/169b5f52_489f0023 :
PS3, Line 122:  #  
the indentation is different here compared to the two lines below. might be good to make this match the other comments or the other two comments match this one.
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/79655?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I843e33f30cd356e4f12330bdfe2d53a0b3920ef3
Gerrit-Change-Number: 79655
Gerrit-PatchSet: 3
Gerrit-Owner: Sheng-Liang Pan sheng-liang.pan@quanta.corp-partner.google.com
Gerrit-Reviewer: David Wu david_wu@quanta.corp-partner.google.com
Gerrit-Reviewer: Derek Huang derekhuang@google.com
Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de
Gerrit-Reviewer: Lucas Chen lucas.chen@quanta.corp-partner.google.com
Gerrit-Reviewer: Sheng-Liang Pan sheng-liang.pan@quanta.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Lucas Chen lucas.chen@quanta.corp-partner.google.com
Gerrit-Attention: Sheng-Liang Pan sheng-liang.pan@quanta.corp-partner.google.com
Gerrit-Comment-Date: Sun, 31 Dec 2023 18:09:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment