Andrey Petrov has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34680 )
Change subject: dram: Add basic DDR4 SPD parsing
......................................................................
Patch Set 4:
(4 comments)
https://review.coreboot.org/c/coreboot/+/34680/3/src/device/dram/ddr4.c
File src/device/dram/ddr4.c:
https://review.coreboot.org/c/coreboot/+/34680/3/src/device/dram/ddr4.c@45
PS3, Line 45:
start with spd[0] to get "Bytes Total" and "Bytes used"
Ack
https://review.coreboot.org/c/coreboot/+/34680/3/src/device/dram/ddr4.c@46
PS3, Line 46: DDR3
DDR4
Ack
https://review.coreboot.org/c/coreboot/+/34680/3/src/device/dram/ddr4.c@80
PS3, Line 80: dimm->manufacturer_id = (spd[351] << 8) | spd[350];
check if 351 is within "Bytes used" in spd[0]
I addressed this in follow up patch that implements crc checks as well: 34781
https://review.coreboot.org/c/coreboot/+/34680/3/src/device/dram/ddr4.c@85
PS3, Line 85: memcpy(dimm->part_number, &spd[329], SPD_DDR4_PART_LEN);
make sure those are properly null terminated
but this is already done on next line
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34680
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If3befbc55cf37e1018baa432cb2f03743b929211
Gerrit-Change-Number: 34680
Gerrit-PatchSet: 4
Gerrit-Owner: Andrey Petrov
anpetrov@fb.com
Gerrit-Reviewer: Andrey Petrov
anpetrov@fb.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-CC: Patrick Rudolph
siro@das-labor.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 07 Aug 2019 20:03:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Patrick Rudolph
patrick.rudolph@9elements.com
Comment-In-Reply-To: Matt DeVillier
matt.devillier@gmail.com
Gerrit-MessageType: comment