Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34725 )
Change subject: soc/intel/skylake: Use new power-failure-state API ......................................................................
Patch Set 3:
(2 comments)
https://review.coreboot.org/c/coreboot/+/34725/3/src/soc/intel/skylake/pmc.c File src/soc/intel/skylake/pmc.c:
https://review.coreboot.org/c/coreboot/+/34725/3/src/soc/intel/skylake/pmc.c... PS3, Line 60: 1 A symbolic constant would be nice
https://review.coreboot.org/c/coreboot/+/34725/3/src/soc/intel/skylake/pmc.c... PS3, Line 62: 1 same