Peichao Li has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/35042 )
Change subject: [TEST-ONLY]Set STAPM percentage for Treeya ......................................................................
[TEST-ONLY]Set STAPM percentage for Treeya
Tuning stapm percent from 80 to 68 meet our thermal requirement
BUG=None TEST=build and boot treeya
Signed-off-by: Peichao Wang peichao.wang@bitland.corp-partner.google.com Change-Id: I254140c9d242ed918b3b689d4fb4a1d0e871cd55 --- M src/mainboard/google/kahlee/variants/treeya/devicetree.cb 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/42/35042/1
diff --git a/src/mainboard/google/kahlee/variants/treeya/devicetree.cb b/src/mainboard/google/kahlee/variants/treeya/devicetree.cb index beb99e0..7005644 100644 --- a/src/mainboard/google/kahlee/variants/treeya/devicetree.cb +++ b/src/mainboard/google/kahlee/variants/treeya/devicetree.cb @@ -20,7 +20,7 @@ register "dram_clear_on_reset" = "DRAM_CONTENTS_KEEP" register "uma_mode" = "UMAMODE_SPECIFIED_SIZE" register "uma_size" = "16 * MiB" - register "stapm_percent" = "80" + register "stapm_percent" = "68" register "stapm_time_ms" = "2500000" register "stapm_power_mw" = "7800"
Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35042 )
Change subject: [TEST-ONLY]Set STAPM percentage for Treeya ......................................................................
Patch Set 1:
Any thoughts about merging this?
Peichao Li has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35042 )
Change subject: [TEST-ONLY]Set STAPM percentage for Treeya ......................................................................
Patch Set 1:
Patch Set 1:
Any thoughts about merging this?
Dear Sir, this cl is not good. So abandon it. Thanks a lot!
Peichao Li has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/35042 )
Change subject: [TEST-ONLY]Set STAPM percentage for Treeya ......................................................................
Abandoned
Peichao Li has restored this change. ( https://review.coreboot.org/c/coreboot/+/35042 )
Change subject: [TEST-ONLY]Set STAPM percentage for Treeya ......................................................................
Restored
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/35042
to look at the new patch set (#2).
Change subject: mb/google/kahlee/treeya: Set STAPM parameters for Treeya ......................................................................
mb/google/kahlee/treeya: Set STAPM parameters for Treeya
Tuning stapm percentage from 80 to 68 and time from 250 second to 90 second make them meet Lenovo temperature spec.
BUG=143859022 TEST=build firmware and install it to DUT and run fishbowl 1000, check temperature whether meet spec.
Signed-off-by: Peichao Wang peichao.wang@bitland.corp-partner.google.com Change-Id: I254140c9d242ed918b3b689d4fb4a1d0e871cd55 --- M src/mainboard/google/kahlee/variants/treeya/devicetree.cb 1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/42/35042/2
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35042 )
Change subject: mb/google/kahlee/treeya: Set STAPM parameters for Treeya ......................................................................
Patch Set 2:
(4 comments)
https://review.coreboot.org/c/coreboot/+/35042/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/35042/2//COMMIT_MSG@7 PS2, Line 7: Set Update
https://review.coreboot.org/c/coreboot/+/35042/2//COMMIT_MSG@9 PS2, Line 9: Tuning Tune
https://review.coreboot.org/c/coreboot/+/35042/2//COMMIT_MSG@9 PS2, Line 9: Tuning stapm percentage from 80 to 68 and time from 250 second : to 90 second make them meet Lenovo temperature spec. Where did you get these values from?
https://review.coreboot.org/c/coreboot/+/35042/2//COMMIT_MSG@14 PS2, Line 14: meet meets
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/35042
to look at the new patch set (#3).
Change subject: mb/google/kahlee/treeya: Update STAPM parameters for Treeya ......................................................................
mb/google/kahlee/treeya: Update STAPM parameters for Treeya
Tune stapm percentage from 80 to 68 and time from 250 second to 90 second make them meet Lenovo temperature spec.
BUG=143859022 TEST=build firmware and install it to DUT and run fishbowl 1000, check temperature whether meets spec.
Signed-off-by: Peichao Wang peichao.wang@bitland.corp-partner.google.com Change-Id: I254140c9d242ed918b3b689d4fb4a1d0e871cd55 --- M src/mainboard/google/kahlee/variants/treeya/devicetree.cb 1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/42/35042/3
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/35042
to look at the new patch set (#4).
Change subject: mb/google/kahlee/treeya: Update STAPM parameters for Treeya ......................................................................
mb/google/kahlee/treeya: Update STAPM parameters for Treeya
Tune stapm percentage from 80 to 68 and time from 250 second to 90 second make them meet Lenovo temperature spec.
BUG=b:143859022 TEST=build firmware and install it to DUT and run fishbowl 1000, check temperature whether meets spec.
Signed-off-by: Peichao Wang peichao.wang@bitland.corp-partner.google.com Change-Id: I254140c9d242ed918b3b689d4fb4a1d0e871cd55 --- M src/mainboard/google/kahlee/variants/treeya/devicetree.cb 1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/42/35042/4
Peichao Li has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35042 )
Change subject: mb/google/kahlee/treeya: Update STAPM parameters for Treeya ......................................................................
Patch Set 4:
(4 comments)
https://review.coreboot.org/c/coreboot/+/35042/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/35042/2//COMMIT_MSG@7 PS2, Line 7: Set
Update
Done
https://review.coreboot.org/c/coreboot/+/35042/2//COMMIT_MSG@9 PS2, Line 9: Tuning
Tune
Done
https://review.coreboot.org/c/coreboot/+/35042/2//COMMIT_MSG@9 PS2, Line 9: Tuning stapm percentage from 80 to 68 and time from 250 second : to 90 second make them meet Lenovo temperature spec.
Where did you get these values from?
Dear Paul, regarding these values, please kindly check ticket: 143859022, our thermal guy has replied. Thanks a lot!
https://review.coreboot.org/c/coreboot/+/35042/2//COMMIT_MSG@14 PS2, Line 14: meet
meets
Done
Peichao Li has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35042 )
Change subject: mb/google/kahlee/treeya: Update STAPM parameters for Treeya ......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35042/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/35042/2//COMMIT_MSG@9 PS2, Line 9: Tuning stapm percentage from 80 to 68 and time from 250 second : to 90 second make them meet Lenovo temperature spec.
Dear Paul, regarding these values, please kindly check ticket: 143859022, our thermal guy has replie […]
Done
Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35042 )
Change subject: mb/google/kahlee/treeya: Update STAPM parameters for Treeya ......................................................................
Patch Set 4: Code-Review+2
Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35042 )
Change subject: mb/google/kahlee/treeya: Update STAPM parameters for Treeya ......................................................................
Patch Set 4: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/35042/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/35042/2//COMMIT_MSG@9 PS2, Line 9: Tuning stapm percentage from 80 to 68 and time from 250 second : to 90 second make them meet Lenovo temperature spec.
Done
Unfortunately, people outside google and partners can't see the buganizer bugs.
STAPM parameters are decided by measuring the skin temperature of a machine while running a (standardized) heavy workload. The temperature isn't allowed to get too hot in any one area, so thermal spreaders are required to allow cooling across a large area. Unfortunately that adds weight and cost, so it's a trade off.
What the STAPM parameters do is basically restrict how much power can go to the processor in a given amount of time before it has time to cool down. At some point in an ongoing heavy workload, it has to balance how much power the processor gets with how much heat can be dissipated.
Martin Roth has submitted this change. ( https://review.coreboot.org/c/coreboot/+/35042 )
Change subject: mb/google/kahlee/treeya: Update STAPM parameters for Treeya ......................................................................
mb/google/kahlee/treeya: Update STAPM parameters for Treeya
Tune stapm percentage from 80 to 68 and time from 250 second to 90 second make them meet Lenovo temperature spec.
BUG=b:143859022 TEST=build firmware and install it to DUT and run fishbowl 1000, check temperature whether meets spec.
Signed-off-by: Peichao Wang peichao.wang@bitland.corp-partner.google.com Change-Id: I254140c9d242ed918b3b689d4fb4a1d0e871cd55 Reviewed-on: https://review.coreboot.org/c/coreboot/+/35042 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Marshall Dawson marshalldawson3rd@gmail.com Reviewed-by: Martin Roth martinroth@google.com --- M src/mainboard/google/kahlee/variants/treeya/devicetree.cb 1 file changed, 2 insertions(+), 2 deletions(-)
Approvals: build bot (Jenkins): Verified Martin Roth: Looks good to me, approved Marshall Dawson: Looks good to me, approved
diff --git a/src/mainboard/google/kahlee/variants/treeya/devicetree.cb b/src/mainboard/google/kahlee/variants/treeya/devicetree.cb index 2e25340..e8477ee 100644 --- a/src/mainboard/google/kahlee/variants/treeya/devicetree.cb +++ b/src/mainboard/google/kahlee/variants/treeya/devicetree.cb @@ -20,8 +20,8 @@ register "dram_clear_on_reset" = "DRAM_CONTENTS_KEEP" register "uma_mode" = "UMAMODE_SPECIFIED_SIZE" register "uma_size" = "16 * MiB" - register "stapm_percent" = "80" - register "stapm_time_ms" = "2500000" + register "stapm_percent" = "68" + register "stapm_time_ms" = "900000" register "stapm_power_mw" = "7800"
# Enable I2C0 for audio, USB3 hub at 400kHz
-
Marshall Dawson (Code Review) -
Martin Roth (Code Review)
-
Paul Menzel (Code Review)
-
Peichao Li (Code Review)