Attention is currently required from: Hung-Te Lin, Yu-Ping Wu.
Yidi Lin has posted comments on this change by Yidi Lin. ( https://review.coreboot.org/c/coreboot/+/85828?usp=email )
Change subject: mb/google/rauru: Determine PCIe init by storage_id ......................................................................
Patch Set 2:
(1 comment)
File src/mainboard/google/rauru/mainboard.c:
https://review.coreboot.org/c/coreboot/+/85828/comment/bba815b8_fb18a93f?usp... : PS2, Line 52: return storage_id() == 3;
Can we modify `storage_type()` to return `enum storage_type` (by renaming `ufs_type`)? We could use […]
I am thinking if we could follow pcie/regulator that has a `soc/storage.h` and a `mainboard_get_storage_type` API. We can also move above definitions to `soc/storage.h`. What do you think ?