Kevin Chiu has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/45642 )
Change subject: mb/google/zork: update GPIO config for berknip ......................................................................
mb/google/zork: update GPIO config for berknip
update telemetry to improve the performance.
BUG=b:168581158 BRANCH=zork TEST=emerge-zork coreboot
Change-Id: Ib93905cd89132664b06f2476e94494e96980642c Signed-off-by: Kevin Chiu kevin.chiu@quantatw.com --- M src/mainboard/google/zork/variants/berknip/overridetree.cb 1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/42/45642/1
diff --git a/src/mainboard/google/zork/variants/berknip/overridetree.cb b/src/mainboard/google/zork/variants/berknip/overridetree.cb index 868db9b..9562939 100644 --- a/src/mainboard/google/zork/variants/berknip/overridetree.cb +++ b/src/mainboard/google/zork/variants/berknip/overridetree.cb @@ -15,9 +15,9 @@ register "stapm_time_constant" = "200" #second register "sustained_power_limit" = "12000" #mw
- register "telemetry_vddcr_vdd_slope" = "62451" #mA + register "telemetry_vddcr_vdd_slope" = "65599" #mA register "telemetry_vddcr_vdd_offset" = "0" - register "telemetry_vddcr_soc_slope" = "27301" #mA + register "telemetry_vddcr_soc_slope" = "29788" #mA register "telemetry_vddcr_soc_offset" = "0"
# End : OPN Performance Configuration
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45642 )
Change subject: mb/google/zork: update GPIO config for berknip ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/c/coreboot/+/45642/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/45642/1//COMMIT_MSG@7 PS1, Line 7: update GPIO config for berknip This is not correct. The change is not really updating GPIO config.
https://review.coreboot.org/c/coreboot/+/45642/1//COMMIT_MSG@9 PS1, Line 9: performance It would be good to record what kind of differences/improvements you observe with the change.
Hello Furquan Shaikh, Martin Roth, Rob Barnes, Aaron Durbin,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/45642
to look at the new patch set (#2).
Change subject: mb/google/zork: update telemetry settings for berknip ......................................................................
mb/google/zork: update telemetry settings for berknip
update telemetry to improve the performance.
BUG=b:168581158 BRANCH=zork TEST=1. emerge-zork coreboot 2. pass AMD SDLE test
Change-Id: Ib93905cd89132664b06f2476e94494e96980642c Signed-off-by: Kevin Chiu kevin.chiu@quantatw.com --- M src/mainboard/google/zork/variants/berknip/overridetree.cb 1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/42/45642/2
Kevin Chiu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45642 )
Change subject: mb/google/zork: update telemetry settings for berknip ......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/coreboot/+/45642/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/45642/1//COMMIT_MSG@7 PS1, Line 7: update GPIO config for berknip
This is not correct. The change is not really updating GPIO config.
sorry the incorrect title, thanks.
https://review.coreboot.org/c/coreboot/+/45642/1//COMMIT_MSG@9 PS1, Line 9: performance
It would be good to record what kind of differences/improvements you observe with the change.
Done
Kevin Chiu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45642 )
Change subject: mb/google/zork: update telemetry settings for berknip ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45642/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/45642/1//COMMIT_MSG@7 PS1, Line 7: update GPIO config for berknip
sorry the incorrect title, thanks.
Done
Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45642 )
Change subject: mb/google/zork: update telemetry settings for berknip ......................................................................
Patch Set 2: Code-Review+2
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45642 )
Change subject: mb/google/zork: update telemetry settings for berknip ......................................................................
Patch Set 2: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/45642 )
Change subject: mb/google/zork: update telemetry settings for berknip ......................................................................
mb/google/zork: update telemetry settings for berknip
update telemetry to improve the performance.
BUG=b:168581158 BRANCH=zork TEST=1. emerge-zork coreboot 2. pass AMD SDLE test
Change-Id: Ib93905cd89132664b06f2476e94494e96980642c Signed-off-by: Kevin Chiu kevin.chiu@quantatw.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/45642 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Aaron Durbin adurbin@chromium.org Reviewed-by: Furquan Shaikh furquan@google.com --- M src/mainboard/google/zork/variants/berknip/overridetree.cb 1 file changed, 2 insertions(+), 2 deletions(-)
Approvals: build bot (Jenkins): Verified Aaron Durbin: Looks good to me, approved Furquan Shaikh: Looks good to me, approved
diff --git a/src/mainboard/google/zork/variants/berknip/overridetree.cb b/src/mainboard/google/zork/variants/berknip/overridetree.cb index 868db9b..9562939 100644 --- a/src/mainboard/google/zork/variants/berknip/overridetree.cb +++ b/src/mainboard/google/zork/variants/berknip/overridetree.cb @@ -15,9 +15,9 @@ register "stapm_time_constant" = "200" #second register "sustained_power_limit" = "12000" #mw
- register "telemetry_vddcr_vdd_slope" = "62451" #mA + register "telemetry_vddcr_vdd_slope" = "65599" #mA register "telemetry_vddcr_vdd_offset" = "0" - register "telemetry_vddcr_soc_slope" = "27301" #mA + register "telemetry_vddcr_soc_slope" = "29788" #mA register "telemetry_vddcr_soc_offset" = "0"
# End : OPN Performance Configuration
-
Aaron Durbin (Code Review) -
Furquan Shaikh (Code Review)
-
Kevin Chiu (Code Review)
-
Patrick Georgi (Code Review)