Attention is currently required from: Alexander Couzens.
Keith Hui has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/85941?usp=email )
Change subject: mb/lenovo/x230: Remove old USB configurations ......................................................................
mb/lenovo/x230: Remove old USB configurations
As of commit a911b7584820 ("mb/*: Remove old USB configurations from SNB/IVB boards") USB configurations are drawn exclusively from devicetree. These stuff should have been removed then.
Drop early_init.c that only contains these old configurations.
Change-Id: I3c92ab408219291fef355c9462134dbbd2e4ea87 Signed-off-by: Keith Hui buurin@gmail.com --- M src/mainboard/lenovo/x230/Makefile.mk D src/mainboard/lenovo/x230/variants/x230/early_init.c D src/mainboard/lenovo/x230/variants/x230s/early_init.c 3 files changed, 0 insertions(+), 43 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/41/85941/1
diff --git a/src/mainboard/lenovo/x230/Makefile.mk b/src/mainboard/lenovo/x230/Makefile.mk index 6e6f9f9..5cbdb7d 100644 --- a/src/mainboard/lenovo/x230/Makefile.mk +++ b/src/mainboard/lenovo/x230/Makefile.mk @@ -1,8 +1,6 @@ ## SPDX-License-Identifier: GPL-2.0-only
-bootblock-y += variants/$(VARIANT_DIR)/early_init.c bootblock-y += variants/$(VARIANT_DIR)/gpio.c -romstage-y += variants/$(VARIANT_DIR)/early_init.c romstage-y += variants/$(VARIANT_DIR)/gpio.c ramstage-y += variants/$(VARIANT_DIR)/hda_verb.c
diff --git a/src/mainboard/lenovo/x230/variants/x230/early_init.c b/src/mainboard/lenovo/x230/variants/x230/early_init.c deleted file mode 100644 index 55a3c08..0000000 --- a/src/mainboard/lenovo/x230/variants/x230/early_init.c +++ /dev/null @@ -1,21 +0,0 @@ -/* SPDX-License-Identifier: GPL-2.0-only */ - -#include <southbridge/intel/bd82x6x/pch.h> -#include <southbridge/intel/common/gpio.h> - -const struct southbridge_usb_port mainboard_usb_ports[] = { - { 1, 0, 0 }, /* P0 (left, fan side), OC 0 */ - { 1, 0, 1 }, /* P1 (left touchpad side), OC 1 */ - { 1, 1, 3 }, /* P2: dock, OC 3 */ - { 1, 1, -1 }, /* P3: wwan, no OC */ - { 1, 1, -1 }, /* P4: Wacom tablet on X230t, otherwise empty */ - { 1, 1, -1 }, /* P5: Expresscard, no OC */ - { 0, 0, -1 }, /* P6: Empty */ - { 1, 2, -1 }, /* P7: dock, no OC */ - { 0, 0, -1 }, /* P8: Empty */ - { 1, 2, 5 }, /* P9: Right (EHCI debug), OC 5 */ - { 1, 1, -1 }, /* P10: fingerprint reader, no OC */ - { 1, 1, -1 }, /* P11: bluetooth, no OC. */ - { 1, 1, -1 }, /* P12: wlan, no OC */ - { 1, 1, -1 }, /* P13: webcam, no OC */ -}; diff --git a/src/mainboard/lenovo/x230/variants/x230s/early_init.c b/src/mainboard/lenovo/x230/variants/x230s/early_init.c deleted file mode 100644 index 16d11a3..0000000 --- a/src/mainboard/lenovo/x230/variants/x230s/early_init.c +++ /dev/null @@ -1,20 +0,0 @@ -/* SPDX-License-Identifier: GPL-2.0-only */ - -#include <southbridge/intel/bd82x6x/pch.h> - -const struct southbridge_usb_port mainboard_usb_ports[] = { - {1, 3, 0}, /* SSP1: Right */ - {1, 3, 1}, /* SSP2: Left, EHCI Debug */ - {0, 1, 3}, /* SSP3 */ - {1, 3, -1}, /* B0P4: WWAN USB */ - {0, 1, 2}, /* B0P5 */ - {0, 1, -1}, /* B0P6 */ - {0, 1, -1}, /* B0P7 */ - {0, 1, -1}, /* B0P8 */ - {0, 1, -1}, /* B1P1 */ - {0, 1, 5}, /* B1P2 */ - {1, 1, -1}, /* B1P3: Fingerprint Reader */ - {0, 1, -1}, /* B1P4 */ - {1, 3, -1}, /* B1P5: WLAN USB */ - {1, 1, -1}, /* B1P6: Camera */ -};
-
Keith Hui (Code Review)