Matt DeVillier has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/37903 )
Change subject: mb/google/eve: select SYSTEM_TYPE_CONVERTIBLE ......................................................................
mb/google/eve: select SYSTEM_TYPE_CONVERTIBLE
select SYSTEM_TYPE_CONVERTIBLE, which properly sets the SMBIOS chassis type, and allows the OS driver to recognize tablet mode capability
Change-Id: Ic61659e9fa6f7428afd1f018fb8cb25fe49e8747 Signed-off-by: Matt DeVillier matt.devillier@gmail.com --- M src/mainboard/google/eve/Kconfig 1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/03/37903/1
diff --git a/src/mainboard/google/eve/Kconfig b/src/mainboard/google/eve/Kconfig index 31ff6e9..dcc5b38 100644 --- a/src/mainboard/google/eve/Kconfig +++ b/src/mainboard/google/eve/Kconfig @@ -21,6 +21,7 @@ select MAINBOARD_HAS_LIBGFXINIT select MAINBOARD_HAS_TPM2 select SOC_INTEL_KABYLAKE + select SYSTEM_TYPE_CONVERTIBLE
config VBOOT select EC_GOOGLE_CHROMEEC_SWITCHES
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37903 )
Change subject: mb/google/eve: select SYSTEM_TYPE_CONVERTIBLE ......................................................................
Patch Set 2: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/37903 )
Change subject: mb/google/eve: select SYSTEM_TYPE_CONVERTIBLE ......................................................................
mb/google/eve: select SYSTEM_TYPE_CONVERTIBLE
select SYSTEM_TYPE_CONVERTIBLE, which properly sets the SMBIOS chassis type, and allows the OS driver to recognize tablet mode capability
Change-Id: Ic61659e9fa6f7428afd1f018fb8cb25fe49e8747 Signed-off-by: Matt DeVillier matt.devillier@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/37903 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Angel Pons th3fanbus@gmail.com --- M src/mainboard/google/eve/Kconfig 1 file changed, 1 insertion(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved
diff --git a/src/mainboard/google/eve/Kconfig b/src/mainboard/google/eve/Kconfig index 31ff6e9..dcc5b38 100644 --- a/src/mainboard/google/eve/Kconfig +++ b/src/mainboard/google/eve/Kconfig @@ -21,6 +21,7 @@ select MAINBOARD_HAS_LIBGFXINIT select MAINBOARD_HAS_TPM2 select SOC_INTEL_KABYLAKE + select SYSTEM_TYPE_CONVERTIBLE
config VBOOT select EC_GOOGLE_CHROMEEC_SWITCHES
-
Angel Pons (Code Review) -
Matt DeVillier (Code Review)
-
Patrick Georgi (Code Review)